Bug 48759 - [GTK] Cleanup needed in testatk.c file
Summary: [GTK] Cleanup needed in testatk.c file
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-11-01 08:23 PDT by Mario Sanchez Prada
Modified: 2010-11-01 14:00 PDT (History)
1 user (show)

See Also:

Patch proposal (70.91 KB, patch)
2010-11-01 08:41 PDT, Mario Sanchez Prada
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2010-11-01 08:23:30 PDT
Currently, this file is not very coherent in its content since some parts of it are written in an old-fashioned (not WebKit's coding-style compliant) way and some other, newer, parts are written in a completely different style. 

On top of that, there's currently the "new trend" in the file of avoiding using an extra main loop in each test by just manually spinning the original main loop before trying to retrieve the accessible objects, which would be more than enough for the tests for properly work.

As a consequence, it would be nice to make some cleanup in this file to prepare it for further modifications, in a way so the whole file uses consistent style and patterns for the unit tests infrastructure.

I have a patch almost ready, attaching it in a while...
Comment 1 Mario Sanchez Prada 2010-11-01 08:24:33 PDT
Adding Martin to CC, as he already showed interest on this matter
Comment 2 Mario Sanchez Prada 2010-11-01 08:41:46 PDT
Created attachment 72510 [details]
Patch proposal

Attaching patch proposal. Asking for review
Comment 3 Mario Sanchez Prada 2010-11-01 14:00:44 PDT
Committed r71052: <http://trac.webkit.org/changeset/71052>