Bug 48716 – [Qt] Support nodesFromRect in DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Robert Hogan]

To do this we need to support passing the document's document-element object across the bridge.

[Robert Hogan]

Created attachment 72434 [details]
Patch

[Antonio Gomes]

Comment on attachment 72434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72434&action=review

> WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:797
> +    RefPtr<NodeList> nodes = doc->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
> +    for (int i = 0; i < nodes->length(); i++) {
> +        QVariant v;
> +        v.setValue(QWebElement(nodes->item(i)));

what happens if nodes->item(i) is a text node? i.e. not a WebCore::Element*

[Antonio Gomes]

Comment on attachment 72434 [details]
Patch

Please add a comment about the known problem on comment #2.

[Robert Hogan]

Andreas, what do you think? Change to qt_runtime ok?

[Robert Hogan]

Created attachment 72439 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 72439 [details]
Patch

Clearing flags on attachment: 72439

Committed r71004: <http://trac.webkit.org/changeset/71004>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71004 might have broken Qt Linux Release
The following tests are not passing:
fast/dom/nodesFromRect-basic.html

[Antonio Gomes]

(In reply to comment #8)
> http://trac.webkit.org/changeset/71004 might have broken Qt Linux Release
> The following tests are not passing:
> fast/dom/nodesFromRect-basic.html

worked locally for me:

$ WEBKITOUTPUTDIR=`pwd`/WebKitBuild/Qt/ run-webkit-tests --qt LayoutTests/fast/dom/nodesFromRect-basic.html 
Running build-dumprendertree
Running tests from /home/agomes/Devel/webkit/webkit/LayoutTests
Testing 1 test cases.
fast/dom .
1.80s total testing time

all 1 test cases succeeded

[Csaba Osztrogonác]

New bug filed on this fail: https://bugs.webkit.org/show_bug.cgi?id=48758