Bug 48713 - [GTK] Add support for <meter> element
Summary: [GTK] Add support for <meter> element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-10-30 06:07 PDT by Yael
Modified: 2011-01-11 10:38 PST (History)
7 users (show)

See Also:


Attachments
Enable meter element in gtk port (55.85 KB, patch)
2010-12-24 03:26 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (55.91 KB, patch)
2010-12-27 04:10 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-10-30 06:07:17 PDT
Need to add support for <meter> element in RenderThemeGtk.cpp
Comment 1 Martin Robinson 2010-10-30 08:09:22 PDT
I can tackle this, if no one else has plans to.
Comment 2 Carlos Garcia Campos 2010-12-24 03:26:15 PST
Created attachment 77410 [details]
Enable meter element in gtk port

We don't need any specific code in RenderThemeGtk. Gtk+ doesn't have a meter widget so there's no way to render them like gtk+. Using the default meter defined in html.css makes exactly the same output than chromium, for example, which I think is acceptable for gtk+ too.
Comment 3 Martin Robinson 2010-12-24 10:49:45 PST
Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps.
Comment 4 Daniel Bates 2010-12-24 12:41:40 PST
Comment on attachment 77410 [details]
Enable meter element in gtk port

View in context: https://bugs.webkit.org/attachment.cgi?id=77410&action=review

> WebCore/GNUmakefile.am:3895
>  # HTML Meter Element - disable for now.

This comment should be updated. In particular, the phrase "disabled for now." should be removed.
Comment 5 Carlos Garcia Campos 2010-12-27 03:38:57 PST
(In reply to comment #3)
> Awesome! Thanks Carlos. Are these results for GTK+ 3.x or 2.x? We should also include pixel dumps.

Both, since we are not using gtk.
Comment 6 Carlos Garcia Campos 2010-12-27 04:10:03 PST
Created attachment 77490 [details]
Updated patch

Updated patch just updating the comment in Makefile as suggested by Daniel Bates
Comment 7 Martin Robinson 2010-12-27 08:54:59 PST
Comment on attachment 77490 [details]
Updated patch

Thanks! Please attach pixel results to this patch before landing it.
Comment 8 Carlos Garcia Campos 2011-01-11 09:32:46 PST
Committed r75507: <http://trac.webkit.org/changeset/75507>
Comment 9 WebKit Review Bot 2011-01-11 10:38:28 PST
http://trac.webkit.org/changeset/75507 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/dom/HTMLMeterElement/meter-element-crash.html
fast/dom/HTMLMeterElement/meter-element-form.html
fast/dom/HTMLMeterElement/meter-element-with-child-crash.html
fast/dom/HTMLMeterElement/meter-element.html
fast/dom/HTMLMeterElement/meter-optimums.html
fast/dom/HTMLMeterElement/meter-percent-size.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/set-meter-properties.html
fast/forms/form-attribute.html