Bug 48711 – Web Inspector: event listener breakpoints are not preserved upon navigation / refresh.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Also, checkboxes should be smaller (as in regular breakpoints).

[Pavel Feldman]

Also, neither DOM nor XHR breakpoints are preserved.

[Pavel Podivilov]

Created attachment 72513 [details]
Patch.

[Pavel Feldman]

Comment on attachment 72513 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=72513&action=review

> WebCore/inspector/front-end/BreakpointManager.js:259
> +        for (var i = 0; i < breakpoints.length; ++i) {

breakpoints can be non-array / empty.

> WebCore/inspector/front-end/BreakpointManager.js:261
> +                this.createEventListenerBreakpoint(breakpoints[i].condition.eventName);

Breakpoint can be of wrong structure here as well.

> WebCore/inspector/front-end/BreakpointManager.js:272
> +        for (var i = 0; i < breakpoints.length; ++i) {

ditto

> WebCore/inspector/front-end/BreakpointManager.js:283
> +        function didPushNodeByPathToFrontend(path, nodeId)

We usually put local functions above the usage.

> WebCore/inspector/front-end/Settings.js:68
> +    this.installProjectSetting("nativeBreakpoints", {});

{} -> []

> WebCore/inspector/front-end/inspector.js:1570
> +    this.applicationSettings.inspectedURLChanged(url);

It is strange that project-related settings that are affected by the URL change are accessed via applicationSettings object.

[Pavel Podivilov]

Created attachment 72642 [details]
Patch.

All comments addressed.

[Pavel Podivilov]

Committed r71109: <http://trac.webkit.org/changeset/71109>