Bug 48706 – Factor calculation of cache sizes based on cache model into shared function.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Factor calculation of cache sizes based on cache model into shared function.

[Sam Weinig]

Created attachment 72426 [details]
Patch

[Adam Barth]

BTW, what's your plan w.r.t. the memory cache and multiprocess?

[Sam Weinig]

(In reply to comment #2)
> BTW, what's your plan w.r.t. the memory cache and multiprocess?

The current model uses a single process for all windows/tabs, so this has not been a problem we have had to solve yet. It will be an interesting problem to try and solve when the time comes though.

[Adam Roben (:aroben)]

Comment on attachment 72426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72426&action=review

> WebKit2/WebProcess/WebProcess.h:106
> +    void calculateCacheSizes(CacheModel cacheModel, uint64_t memorySize, uint64_t diskFreeSize,

Seems like this can be a static member function.

> WebKit2/WebProcess/mac/WebProcessMac.mm:67
>  void WebProcess::platformSetCacheModel(CacheModel cacheModel)
>  {
> +    NSURLCache *nsurlCache = [NSURLCache sharedURLCache];

Why did you move this up to the top? Was it a bug that it was lower down before? You should explain this in your ChangeLog.

> WebKit2/WebProcess/mac/WebProcessMac.mm:94
> +    [nsurlCache setDiskCapacity:std::max(urlCacheDiskCapacity, [nsurlCache diskCapacity])]; // Don't shrink a big disk cache, since that would cause churn.

Why is std:: needed here? Normally we use "using namespace std;" so you don't have to write that.

[Sam Weinig]

Landed in r71658.