Bug 48700 - [Qt] IM: Don't manipulate selection via RenderTextControl
Summary: [Qt] IM: Don't manipulate selection via RenderTextControl
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-10-29 17:16 PDT by Andreas Kling
Modified: 2010-10-30 07:51 PDT (History)
3 users (show)

See Also:

Proposed patch (4.70 KB, patch)
2010-10-29 17:18 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-29 17:16:53 PDT
As brought up by Ryosuke Niwa on IRC, Qt's Input Method API shouldn't be accessing the selection through RenderTextControl.
We should go directly through the Frame's SelectionController instead.
Comment 1 Andreas Kling 2010-10-29 17:18:26 PDT
Created attachment 72417 [details]
Proposed patch
Comment 2 Andreas Kling 2010-10-30 07:51:43 PDT
Comment on attachment 72417 [details]
Proposed patch

Clearing flags on attachment: 72417

Committed r70982: <http://trac.webkit.org/changeset/70982>
Comment 3 Andreas Kling 2010-10-30 07:51:54 PDT
All reviewed patches have been landed.  Closing bug.