Bug 48692 - [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
Summary: [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-29 15:31 PDT by Andreas Kling
Modified: 2010-11-03 10:24 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (559 bytes, patch)
2010-10-29 15:32 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Proposed patch (1017 bytes, patch)
2010-10-29 16:10 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-29 15:31:33 PDT 
Due to a missing break statement, QWebPage::event() falls through to QEvent::ShortcutOverride after handling QEvent::InputMethod and calls shortCutOverrideEvent() with a QInputMethodEvent cast to a QKeyEvent. Oops!
Comment 1 Andreas Kling 2010-10-29 15:32:55 PDT 
Created attachment 72408 [details]
Proposed patch
Comment 2 Andreas Kling 2010-10-29 16:10:36 PDT 
Created attachment 72413 [details]
Proposed patch

Ahem..
Comment 3 Ariya Hidayat 2010-10-29 16:23:14 PDT 
Comment on attachment 72413 [details]
Proposed patch

LGTM.
Comment 4 Andreas Kling 2010-10-29 16:25:04 PDT 
Comment on attachment 72413 [details]
Proposed patch

Clearing flags on attachment: 72413

Committed r70948: <http://trac.webkit.org/changeset/70948>
Comment 5 Andreas Kling 2010-10-29 16:25:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Andreas Kling 2010-10-29 16:28:54 PDT 
Blocking 2.1 on this since it's trivial and obviously fixes a bug.
Comment 7 Ademar Reis 2010-11-03 10:23:48 PDT 
Revision r70948 cherry-picked into qtwebkit-2.1 with commit 0e4d96b <http://gitorious.org/webkit/qtwebkit/commit/0e4d96b>