Bug 48672 - Make vertical hit testing for glyph offsets of InlineTextBoxes work.
Summary: Make vertical hit testing for glyph offsets of InlineTextBoxes work.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-10-29 14:12 PDT by Dave Hyatt
Modified: 2010-11-02 15:23 PDT (History)
0 users

See Also:

Attachments
Patch (64.09 KB, patch)
2010-11-02 12:58 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (67.25 KB, patch)
2010-11-02 13:01 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-29 14:12:19 PDT 
Make vertical hit testing of InlineTextBoxes work.  Painting has been patched, but hit testing has not.
Comment 1 Dave Hyatt 2010-11-02 12:58:17 PDT 
Created attachment 72720 [details]
Patch
Comment 2 Dave Hyatt 2010-11-02 13:01:13 PDT 
Created attachment 72722 [details]
Patch
Comment 3 Dave Hyatt 2010-11-02 15:23:52 PDT 
Fixed in r71177,

Note there were three bugs in the patch, caught by layout test failures.

(1) The top/bottomVisibleOverflows for painting/hit testing needed to be logicalTop/logicalBottom.
(2) The logicalPointEnd needed a +1 put on it (since a padding of 0 still equals an extent of 1).
(3) The rect values for hit testing were backwards.