Bug 48664 - Make repaint invalidation work with flipped blocks ("rl" and "bt")
Summary: Make repaint invalidation work with flipped blocks ("rl" and "bt")
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-10-29 12:35 PDT by Dave Hyatt
Modified: 2010-11-11 14:55 PST (History)
3 users (show)

See Also:

Attachments
Patch (58.09 KB, patch)
2010-11-11 13:46 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (59.40 KB, patch)
2010-11-11 13:48 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-29 12:35:11 PDT 
Make repaint invalidation work with flipped blocks ("rl" and "bt")
Comment 1 Dave Hyatt 2010-11-11 13:46:42 PST 
Created attachment 73652 [details]
Patch
Comment 2 Dave Hyatt 2010-11-11 13:48:22 PST 
Created attachment 73653 [details]
Patch
Comment 3 Simon Fraser (smfr) 2010-11-11 14:01:28 PST 
Comment on attachment 73653 [details]
Patch

r=me but I'd like to see more comments (as discussed on irc).
Comment 4 Dave Hyatt 2010-11-11 14:10:59 PST 
(In reply to comment #3)
> (From update of attachment 73653 [details])
> r=me but I'd like to see more comments (as discussed on irc).

I added some comments to the headers and then wrote a novella in RenderBox::computeRectForRepaint.
Comment 5 Dave Hyatt 2010-11-11 14:17:58 PST 
Fixed in r71851.
Comment 6 WebKit Review Bot 2010-11-11 14:55:24 PST 
http://trac.webkit.org/changeset/71851 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/table/colspanMinWidth-vertical.html