RESOLVED FIXED 48663
Make repaint invalidation work with vertical lines. 
https://bugs.webkit.org/show_bug.cgi?id=48663
Summary Make repaint invalidation work with vertical lines.
Dave Hyatt
Reported 2010-10-29 12:34:28 PDT
Make repaint invalidation work with vertical lines.
Attachments
Patch (32.41 KB, patch)
2010-10-29 14:21 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (31.97 KB, patch)
2010-10-29 14:48 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (206.75 KB, patch)
2010-10-29 15:32 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (243.68 KB, patch)
2010-11-01 11:39 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-29 14:21:23 PDT
Created attachment 72393 [details] Patch
Dave Hyatt
Comment 2 2010-10-29 14:48:04 PDT
Created attachment 72398 [details] Patch
Dave Hyatt
Comment 3 2010-10-29 15:32:39 PDT
Created attachment 72407 [details] Patch
Dave Hyatt
Comment 4 2010-10-29 17:39:01 PDT
Fixed in r70959.
WebKit Review Bot
Comment 5 2010-10-29 18:54:10 PDT
http://trac.webkit.org/changeset/70959 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 64-bit Debug The following tests are not passing: fast/events/spatial-navigation/snav-clipped-overflowed-content.html fast/events/spatial-navigation/snav-iframe-nested.html
Darin Adler
Comment 6 2010-10-30 14:33:59 PDT
I agree with the bot. After this patch, two of the spatial-navigation tests are failing on all platforms. It’s the reason there is so much red on the bots. Hyatt, can you figure out what’s up and make the bots happy again?
Antonio Gomes
Comment 7 2010-10-31 05:47:54 PDT
(In reply to comment #6) > I agree with the bot. After this patch, two of the spatial-navigation tests are failing on all platforms. It’s the reason there is so much red on the bots. > > Hyatt, can you figure out what’s up and make the bots happy again? They actually failed in all mac tests builds, as well as qt , gtk bots. Hyatt, I would be glad to help fixing it too. they are still failing ...
Csaba Osztrogonác
Comment 8 2010-10-31 10:36:47 PDT
(In reply to comment #5) > http://trac.webkit.org/changeset/70959 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 64-bit Debug > The following tests are not passing: > fast/events/spatial-navigation/snav-clipped-overflowed-content.html > fast/events/spatial-navigation/snav-iframe-nested.html Rolled out by http://trac.webkit.org/changeset/70991, because t he whole tree and commit queue were broken because of r70959.
Csaba Osztrogonác
Comment 9 2010-10-31 10:37:33 PDT
Comment on attachment 72407 [details] Patch remove r+ from landed and rolled-out patch
Dave Hyatt
Comment 10 2010-11-01 11:39:15 PDT
Created attachment 72530 [details] Patch The previous patch flipped a left and a top by accident in linesVisibleOverflowBoundingBox, and that's what caused the spatial navigation tests to fail.
mitz
Comment 11 2010-11-01 11:49:01 PDT
Comment on attachment 72530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72530&action=review > WebCore/ChangeLog:15 > + * WebCore.xcodeproj/project.pbxproj: Don’t land this change.
Dave Hyatt
Comment 12 2010-11-01 12:07:41 PDT
Fixed in r71043.
WebKit Review Bot
Comment 13 2010-11-01 12:38:37 PDT
http://trac.webkit.org/changeset/71043 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/text/international/vertical-text-glyph-test.html
Note You need to log in before you can comment on or make changes to this bug.