Bug 48657 - [chromium] add debug logging to help diagnose flakiness dashboard issues
Summary: [chromium] add debug logging to help diagnose flakiness dashboard issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-29 12:14 PDT by Ojan Vafai
Modified: 2010-10-29 15:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2010-10-29 12:16 PDT, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-10-29 12:14:42 PDT
[chromium] add debug logging to help diagnose flakiness dashboard issues
Comment 1 Ojan Vafai 2010-10-29 12:16:01 PDT
Created attachment 72365 [details]
Patch
Comment 2 Tony Chang 2010-10-29 12:19:54 PDT
Comment on attachment 72365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72365&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:966
>          files = [(file, os.path.join(self._options.results_directory, file))
>              for file in json_files]

Using a tuple here instead of a struct-like class makes me sad.
Comment 3 Ojan Vafai 2010-10-29 13:58:26 PDT
This seems to be resolved. Didn't end up committing.
Comment 4 Ojan Vafai 2010-10-29 14:02:41 PDT
Sigh. nm. Still need this. Will commit shortly.
Comment 5 Ojan Vafai 2010-10-29 14:06:26 PDT
Committed r70924: <http://trac.webkit.org/changeset/70924>
Comment 6 WebKit Review Bot 2010-10-29 15:34:08 PDT
http://trac.webkit.org/changeset/70924 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests)
The following tests are not passing:
media/controls-drag-timebar.html