Bug 48623 - Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
Summary: Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 47905
  Show dependency tree / graph
 
Reported: 2010-10-29 03:30 PDT by Nikolas Zimmermann
Modified: 2010-10-29 09:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (38.87 KB, patch)
2010-10-29 03:41 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch v2 (57.36 KB, patch)
2010-10-29 06:34 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-10-29 03:30:01 PDT 
Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
Comment 1 Nikolas Zimmermann 2010-10-29 03:41:31 PDT 
Created attachment 72312 [details]
Patch

My local build is not yet done, I only did the mechanics. But as EWS is not busy right now, I'll keep it busy :-)
Comment 2 Dirk Schulze 2010-10-29 04:08:01 PDT 
Comment on attachment 72312 [details]
Patch

r=me
Comment 3 Eric Seidel (no email) 2010-10-29 05:21:06 PDT 
Attachment 72312 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4870031
Comment 4 Nikolas Zimmermann 2010-10-29 05:30:33 PDT 
Comment on attachment 72312 [details]
Patch

It only builds on mac after touching CodeGeneratorObjC.pm, dependency tracking is obviously broken. If I only modfiy CodeGenerator.pm, the objc bindings are not regenerated,  only the js bindings :/

I'll need to add whitespace to CodeGeneratorObjC.pm, to fix the build.
Found a local regression though, need to investigate first, clearing Dirks r+ for the meanwhile.
Comment 5 Nikolas Zimmermann 2010-10-29 06:34:53 PDT 
Created attachment 72328 [details]
Patch v2

Fixed regressions, while cleaning up the code, yay :-)
Comment 6 Dirk Schulze 2010-10-29 06:41:36 PDT 
Comment on attachment 72328 [details]
Patch v2

Good catch! r=me
Comment 7 Nikolas Zimmermann 2010-10-29 06:54:02 PDT 
Landed in r70872.
Comment 8 Eric Seidel (no email) 2010-10-29 09:25:59 PDT 
Please file a bug about the broken dependency tracking so we can get it fixed.
Comment 9 Nikolas Zimmermann 2010-10-29 09:28:17 PDT 
(In reply to comment #8)
> Please file a bug about the broken dependency tracking so we can get it fixed.
Yeah, thanks for reminding me, I filed 48641.