RESOLVED FIXED 48623
Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept 
https://bugs.webkit.org/show_bug.cgi?id=48623
Summary Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff ...
Nikolas Zimmermann
Reported 2010-10-29 03:30:01 PDT
Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
Attachments
Patch (38.87 KB, patch)
2010-10-29 03:41 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (57.36 KB, patch)
2010-10-29 06:34 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-29 03:41:31 PDT
Created attachment 72312 [details] Patch My local build is not yet done, I only did the mechanics. But as EWS is not busy right now, I'll keep it busy :-)
Dirk Schulze
Comment 2 2010-10-29 04:08:01 PDT
Comment on attachment 72312 [details] Patch r=me
Eric Seidel (no email)
Comment 3 2010-10-29 05:21:06 PDT
Attachment 72312 [details] did not build on mac: Build output: http://queues.webkit.org/results/4870031
Nikolas Zimmermann
Comment 4 2010-10-29 05:30:33 PDT
Comment on attachment 72312 [details] Patch It only builds on mac after touching CodeGeneratorObjC.pm, dependency tracking is obviously broken. If I only modfiy CodeGenerator.pm, the objc bindings are not regenerated, only the js bindings :/ I'll need to add whitespace to CodeGeneratorObjC.pm, to fix the build. Found a local regression though, need to investigate first, clearing Dirks r+ for the meanwhile.
Nikolas Zimmermann
Comment 5 2010-10-29 06:34:53 PDT
Created attachment 72328 [details] Patch v2 Fixed regressions, while cleaning up the code, yay :-)
Dirk Schulze
Comment 6 2010-10-29 06:41:36 PDT
Comment on attachment 72328 [details] Patch v2 Good catch! r=me
Nikolas Zimmermann
Comment 7 2010-10-29 06:54:02 PDT
Landed in r70872.
Eric Seidel (no email)
Comment 8 2010-10-29 09:25:59 PDT
Please file a bug about the broken dependency tracking so we can get it fixed.
Nikolas Zimmermann
Comment 9 2010-10-29 09:28:17 PDT
(In reply to comment #8) > Please file a bug about the broken dependency tracking so we can get it fixed. Yeah, thanks for reminding me, I filed 48641.
Note You need to log in before you can comment on or make changes to this bug.