Bug 48608 – Add text-combine property support to CSS parser

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Takumi Takano]

Add text-combine property to our property list. Reflect the setting to a RenderStyle object.

[Takumi Takano]

Created attachment 72306 [details]
Proposed patch

[Dave Hyatt]

Comment on attachment 72306 [details]
Proposed patch

I would prefer it if TextCombine was put in StyleRareNonInheritedData instead.  In general we're trying to keep the CSS3 stuff out of the original set of inherited/noninherited flags, since they will be rarely used.  I let writing-mode slide originally, since I figured it would end up unprefixed eventually and be compatible with WinIE, but text-combine is going to be pretty obscure, so let's put it in the rare struct.

[Takumi Takano]

Created attachment 72427 [details]
New patch

Moved textCombine into StyleRareNonInheritedData as Dave suggested.

[Takumi Takano]

Created attachment 72428 [details]
(forgot to set review flag...)

[chris fleizach]

Comment on attachment 72428 [details]
(forgot to set review flag...)

looks ok.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72428 [details]:

webarchive/test-link-rel-icon.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 72428 [details]
(forgot to set review flag...)

Rejecting patch 72428 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 72428]" exit_code: 2
Last 500 characters of output:
ng/style/StyleRareNonInheritedData.h
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/LayoutTests/fast/text/international/text-combine-parser-test.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 572


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/4906020

[Takumi Takano]

Created attachment 72791 [details]
Fixed commit error. (Removed tab chars from my test.)

[WebKit Commit Bot]

Comment on attachment 72791 [details]
Fixed commit error. (Removed tab chars from my test.)

Clearing flags on attachment: 72791

Committed r71218: <http://trac.webkit.org/changeset/71218>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71218 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
svg/css/getComputedStyle-basic.xhtml

[Daniel Bates]

(In reply to comment #11)
> http://trac.webkit.org/changeset/71218 might have broken GTK Linux 64-bit Debug
> The following tests are not passing:
> svg/css/getComputedStyle-basic.xhtml

Committed fix in changeset 71225 <http://trac.webkit.org/changeset/71225>; removed platform-specific GTK results so that GTK DRT uses the platform-independent results.