r69226 fixed a bug with retrieving main resources out of webcore's appcache upon redirection. Ironically, chrome didn't exhibit a bug in this regard until this patch was landed. It broke chrome's handling of this case.
Created attachment 72277 [details] fix regression
Comment on attachment 72277 [details] fix regression OK. This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble.
(In reply to comment #2) > (From update of attachment 72277 [details]) > OK. > > This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble. Why do you say that name conflicts? "A cache host is a Document or a SharedWorkerGlobalScope object. A cache host can be associated with an application cache." This class is the class that instills a document or shared worker with that ability.
The translation of "is a" relationship into C++ is very unambiguous. It's inheritance. To match the HTML5 model, a class named ApplicationCacheHost (if one exists) has to be a parent class of Document.
Committed r70923: <http://trac.webkit.org/changeset/70923>
http://trac.webkit.org/changeset/70923 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests) The following tests are not passing: media/controls-drag-timebar.html