RESOLVED FIXED 48592
[Chrome] Need to fix an appcache regression introduced in r69226 
https://bugs.webkit.org/show_bug.cgi?id=48592
Summary [Chrome] Need to fix an appcache regression introduced in r69226
Michael Nordman
Reported 2010-10-28 16:48:18 PDT
r69226 fixed a bug with retrieving main resources out of webcore's appcache upon redirection. Ironically, chrome didn't exhibit a bug in this regard until this patch was landed. It broke chrome's handling of this case.
Attachments
fix regression (4.59 KB, patch)
2010-10-28 18:01 PDT, Michael Nordman 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Nordman
Comment 1 2010-10-28 18:01:47 PDT
Created attachment 72277 [details] fix regression
Alexey Proskuryakov
Comment 2 2010-10-28 20:39:16 PDT
Comment on attachment 72277 [details] fix regression OK. This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble.
Michael Nordman
Comment 3 2010-10-29 13:15:09 PDT
(In reply to comment #2) > (From update of attachment 72277 [details]) > OK. > > This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble. Why do you say that name conflicts? "A cache host is a Document or a SharedWorkerGlobalScope object. A cache host can be associated with an application cache." This class is the class that instills a document or shared worker with that ability.
Alexey Proskuryakov
Comment 4 2010-10-29 13:22:16 PDT
The translation of "is a" relationship into C++ is very unambiguous. It's inheritance. To match the HTML5 model, a class named ApplicationCacheHost (if one exists) has to be a parent class of Document.
Michael Nordman
Comment 5 2010-10-29 14:07:04 PDT
Committed r70923: <http://trac.webkit.org/changeset/70923>
WebKit Review Bot
Comment 6 2010-10-29 15:34:01 PDT
http://trac.webkit.org/changeset/70923 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests) The following tests are not passing: media/controls-drag-timebar.html
Note You need to log in before you can comment on or make changes to this bug.