Bug 48574 - Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
Summary: Change BackForwardList clients to use BackForwardListImpl to prepare for furt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 16:19 PDT by Darin Adler
Modified: 2010-10-29 14:38 PDT (History)
1 user (show)

See Also:


Attachments
Patch (31.88 KB, patch)
2010-10-28 16:24 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-10-28 16:19:56 PDT
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
Comment 1 Darin Adler 2010-10-28 16:24:19 PDT
Created attachment 72254 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-28 16:26:38 PDT
Attachment 72254 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/WebBackForwardList.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory.cpp"
WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory_p.h"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2010-10-29 14:38:33 PDT
Committed r70931: <http://trac.webkit.org/changeset/70931>