UUID generation does not work in Linux that has sandbox turned on.
Created attachment 72262 [details]
Created attachment 72268 [details]
Comment on attachment 72268 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=72268&action=review
A few nits.
r- because it implements it in the case where it should probably stay unimplemented...
Is there a specific benefit in enabling it for everything else? Why not limit to LINUX + CHROMIUM? If the bug is about Chromium Linux implementation, then it should be narrowly scoped, otherwise there should be a note why specifically the previously unimplemented functionality should be implemented.
> + for (size_t i = 0; i < sizeof(randomData) / sizeof(unsigned); ++i)
.. / sizeof(randomData) ?
> + builder.append(String::format("%03x", randomData >> 16));
seems it has to be (randomData >> 16 ) & 0x00000fff here...
Created attachment 72276 [details]
Comment on attachment 72276 [details]
Committed as http://trac.webkit.org/changeset/70830
Why don't we just use this code on all platforms? I don't see the value in calling the platform-specific libraries.
(In reply to comment #7)
> Why don't we just use this code on all platforms? I don't see the value in calling the platform-specific libraries.
I will watch this for a while. If we do not see any problem, we can start to extend to all other platforms.