Bug 48567 - webkit-patch upload calls changed_files more often than it should
Summary: webkit-patch upload calls changed_files more often than it should
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 14:42 PDT by Eric Seidel (no email)
Modified: 2010-10-28 16:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.92 KB, patch)
2010-10-28 15:21 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-28 14:42:31 PDT 
webkit-patch upload calls changed_files more often than it should
Comment 1 Eric Seidel (no email) 2010-10-28 15:21:35 PDT 
Created attachment 72243 [details]
Patch
Comment 2 Adam Barth 2010-10-28 15:42:30 PDT 
Comment on attachment 72243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72243&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/upload.py:157
> -            bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit)
> +            changed_files = self._tool.scm().changed_files(options.git_commit)
> +            state["changed_files"] = changed_files
> +            bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit, changed_files)

Its lame that you need to do this manually.  The steps have a slick way of doing this automatically.
Comment 3 WebKit Commit Bot 2010-10-28 16:01:57 PDT 
Comment on attachment 72243 [details]
Patch

Clearing flags on attachment: 72243

Committed r70820: <http://trac.webkit.org/changeset/70820>
Comment 4 WebKit Commit Bot 2010-10-28 16:02:03 PDT 
All reviewed patches have been landed.  Closing bug.