Bug 48565 - SCM.git_commit_from_svn_revision and svn_revision_from_git_commit should use a shared cache
Summary: SCM.git_commit_from_svn_revision and svn_revision_from_git_commit should use ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 48500
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-28 14:14 PDT by Eric Seidel (no email)
Modified: 2010-10-28 14:14 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-28 14:14:19 PDT 
SCM.git_commit_from_svn_revision and svn_revision_from_git_commit should use a shared cache

I originally implemented these with a shared cache, but then went with a more general @memoized solution instead.  However in some cases we definitely do the lookup in both directions:

Fetching: https://bugs.webkit.org/show_bug.cgi?id=48562&ctype=xml
webkitpy.common.system: [DEBUG] "git log --remove-empty --pretty=format:%H -5 -- /Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py" took 6.05s
webkitpy.common.system: [DEBUG] "git svn find-rev bfdc84421fe0dda8110982eea447d39381ebe56b" took 0.86s
webkitpy.common.system: [DEBUG] "git svn find-rev fdca321d8ef5da39a95e9ac80caad388cfe89b57" took 0.21s
webkitpy.common.system: [DEBUG] "git svn find-rev 3e299cd3c1962b3d4bbcbc726ebcf327fa4886ba" took 0.21s
webkitpy.common.system: [DEBUG] "git svn find-rev b8bdbaa8df0da17daaa41d7e90827e504991b01d" took 0.21s
webkitpy.common.system: [DEBUG] "git svn find-rev 357592e0739bc5122fd47bb67e43899c8d8a54e3" took 0.23s
webkitpy.common.system: [DEBUG] "git svn find-rev r63004" took 0.40s
webkitpy.common.system: [DEBUG] "git log -1 --pretty=format:%ce 357592e0739bc5122fd47bb67e43899c8d8a54e3" took 0.03s
webkitpy.common.system: [DEBUG] "git show --pretty=format: --name-only 357592e0739bc5122fd47bb67e43899c8d8a54e3" took 0.05s
webkitpy.common.system: [DEBUG] "git show 357592e0739bc5122fd47bb67e43899c8d8a54e3:WebKitTools/ChangeLog" took 0.05s
webkitpy.common.system: [DEBUG] "git svn find-rev r70274" took 0.26s
webkitpy.common.system: [DEBUG] "git log -1 --pretty=format:%ce bfdc84421fe0dda8110982eea447d39381ebe56b" took 0.01s
webkitpy.common.system: [DEBUG] "git show --pretty=format: --name-only bfdc84421fe0dda8110982eea447d39381ebe56b" took 0.01s
webkitpy.common.system: [DEBUG] "git show bfdc84421fe0dda8110982eea447d39381ebe56b:WebKitTools/ChangeLog" took 0.03s
webkitpy.common.system: [DEBUG] "git svn find-rev r70059" took 0.28s
webkitpy.common.system: [DEBUG] "git log -1 --pretty=format:%ce fdca321d8ef5da39a95e9ac80caad388cfe89b57" took 0.01s
webkitpy.common.system: [DEBUG] "git show --pretty=format: --name-only fdca321d8ef5da39a95e9ac80caad388cfe89b57" took 0.01s
webkitpy.common.system: [DEBUG] "git show fdca321d8ef5da39a95e9ac80caad388cfe89b57:WebKitTools/ChangeLog" took 0.02s
webkitpy.common.system: [DEBUG] "git svn find-rev r70020" took 0.26s
webkitpy.common.system: [DEBUG] "git log -1 --pretty=format:%ce b8bdbaa8df0da17daaa41d7e90827e504991b01d" took 0.01s
webkitpy.common.system: [DEBUG] "git show --pretty=format: --name-only b8bdbaa8df0da17daaa41d7e90827e504991b01d" took 0.01s
webkitpy.common.system: [DEBUG] "git show b8bdbaa8df0da17daaa41d7e90827e504991b01d:WebKitTools/ChangeLog" took 0.02s
webkitpy.common.system: [DEBUG] "git svn find-rev r70023" took 0.26s
webkitpy.common.system: [DEBUG] "git log -1 --pretty=format:%ce 3e299cd3c1962b3d4bbcbc726ebcf327fa4886ba" took 0.01s
webkitpy.common.system: [DEBUG] "git show --pretty=format: --name-only 3e299cd3c1962b3d4bbcbc726ebcf327fa4886ba" took 0.01s
webkitpy.common.system: [DEBUG] "git show 3e299cd3c1962b3d4bbcbc726ebcf327fa4886ba:WebKitTools/ChangeLog" took 0.02s