Bug 48552 - Mouse events never reach Flash in WebKit2 on Mac (asserts in Debug builds)
Summary: Mouse events never reach Flash in WebKit2 on Mac (asserts in Debug builds)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://www.communitymx.com/content/so...
Keywords: InRadar, PlatformOnly
Depends on: 48694
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-28 13:08 PDT by Adam Roben (:aroben)
Modified: 2010-11-01 06:25 PDT (History)
4 users (show)

See Also:

Attachments
Stop using encode/decodeBytes for WebEvent subclasses (12.66 KB, patch)
2010-10-29 16:35 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-28 13:08:33 PDT 
To reproduce:

1. Go to http://youtube.com/ and try to interact with any video

The video doesn't respond to any mouse events. In Debug builds, you'll get an assertion in ArgumentDecoder::decodeBytes:

ASSERT(size == bufferSize);

size is 56, bufferSize is 52
Comment 1 Adam Roben (:aroben) 2010-10-28 13:12:48 PDT 
This happens when handling a HandleMouseEnterEvent. Presumably the issue is that WebMouseEvent is 52 bytes in 32-bit builds, and 56 bytes in 64-bit builds. Perhaps this is due to different padding?
Comment 2 Adam Roben (:aroben) 2010-10-28 13:37:16 PDT 
<rdar://problem/8606571>
Comment 3 Adam Roben (:aroben) 2010-10-28 13:37:58 PDT 
Seems like we should add a WebEvent.cpp, or perhaps even WebMouseEvent.cpp/h!
Comment 4 Adam Roben (:aroben) 2010-10-29 16:35:38 PDT 
Created attachment 72415 [details]
Stop using encode/decodeBytes for WebEvent subclasses
Comment 5 Anders Carlsson 2010-10-29 16:38:45 PDT 
Comment on attachment 72415 [details]
Stop using encode/decodeBytes for WebEvent subclasses

View in context: https://bugs.webkit.org/attachment.cgi?id=72415&action=review

> WebKit2/Shared/WebKeyboardEvent.cpp:60
> +                                t.m_nativeVirtualKeyCode, t.m_isAutoRepeat, t.m_isKeypad, t.m_isSystemKey));

Not sure if it is, but this should all be on one line!
Comment 6 Early Warning System Bot 2010-10-29 16:46:34 PDT 
Attachment 72415 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4853082
Comment 7 Adam Roben (:aroben) 2010-10-29 16:46:45 PDT 
Committed r70954: <http://trac.webkit.org/changeset/70954>
Comment 8 Csaba Osztrogonác 2010-10-29 18:11:46 PDT 
(In reply to comment #6)
> Attachment 72415 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/4853082

Guys, it wasn't a fair-play game ... Qt EWS was red, but
you committed the wrong patch, and the Qt build is broken 
since 1,5 hours ago. :-S
Comment 9 Csaba Osztrogonác 2010-10-31 05:55:34 PDT 
(In reply to comment #8)
> (In reply to comment #6)
> > Attachment 72415 [details] [details] did not build on qt:
> > Build output: http://queues.webkit.org/results/4853082
> 
> Guys, it wasn't a fair-play game ... Qt EWS was red, but
> you committed the wrong patch, and the Qt build is broken 
> since 1,5 hours ago. :-S

Kling fixed it in http://trac.webkit.org/changeset/70964
Comment 10 Adam Roben (:aroben) 2010-11-01 06:25:09 PDT 
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #6)
> > > Attachment 72415 [details] [details] [details] did not build on qt:
> > > Build output: http://queues.webkit.org/results/4853082
> > 
> > Guys, it wasn't a fair-play game ... Qt EWS was red, but
> > you committed the wrong patch, and the Qt build is broken 
> > since 1,5 hours ago. :-S
> 
> Kling fixed it in http://trac.webkit.org/changeset/70964

Sorry for the trouble. I've been paying attention to the Qt-EWS in general, and find it extremely useful. I guess I wasn't thinking on this one. Thanks for cleaning up my mess!