Bug 48551 - HTMLDocument::isFrameSet() should not depend on renderer
Summary: HTMLDocument::isFrameSet() should not depend on renderer
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2010-10-28 12:53 PDT by Alexey Proskuryakov
Modified: 2010-10-28 13:36 PDT (History)
0 users

See Also:

proposed patch (1.89 KB, patch)
2010-10-28 13:13 PDT, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-10-28 12:53:55 PDT
It's confusing to have both DOM and renderer checks in one function.

There are only two callers of Document::isFrameSet():
1. LegacyWebArchive::createFromSelection(). It doesn't seem to depend on render tree at all.
2. FrameLoader::shouldScrollToAnchor(). Returning true from Document::isFrameSet() means that we won't scroll, which seems like a good idea if there's no renderer.
Comment 1 Alexey Proskuryakov 2010-10-28 13:12:36 PDT
The check has been there since the method was added in <http://trac.webkit.org/changeset/1564>.
Comment 2 Alexey Proskuryakov 2010-10-28 13:13:11 PDT
Created attachment 72222 [details]
proposed patch
Comment 3 Alexey Proskuryakov 2010-10-28 13:36:17 PDT
Committed <http://trac.webkit.org/changeset/70804>.