Bug 48548 - [GTK] Avoid font hinting in the DRT
Summary: [GTK] Avoid font hinting in the DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 12:16 PDT by Alejandro G. Castro
Modified: 2010-11-05 04:40 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (4.68 KB, patch)
2010-10-29 02:33 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Proposed patch (5.03 KB, patch)
2010-10-29 02:50 PDT, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
Rebaseline patch 1 (1.85 MB, patch)
2010-10-29 02:51 PDT, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
Rebaseline patch 2 (1.27 MB, patch)
2010-10-29 02:52 PDT, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
Rebaseline patch 3 (1.37 MB, patch)
2010-10-29 02:52 PDT, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-10-28 12:16:11 PDT 
We have to avoid activating the hinting when testing with the DRT, it gives different results depending on the distribution
Comment 1 Alejandro G. Castro 2010-10-29 02:33:16 PDT 
Created attachment 72302 [details]
Proposed patch

I'll add the rebaselines to other patches to divide the patch.
Comment 2 Alejandro G. Castro 2010-10-29 02:50:57 PDT 
Created attachment 72307 [details]
Proposed patch

Fix Changelog style, the patch with just the modification to avoid hinting.
Comment 3 Alejandro G. Castro 2010-10-29 02:51:55 PDT 
Created attachment 72308 [details]
Rebaseline patch 1
Comment 4 Alejandro G. Castro 2010-10-29 02:52:23 PDT 
Created attachment 72309 [details]
Rebaseline patch 2
Comment 5 Alejandro G. Castro 2010-10-29 02:52:54 PDT 
Created attachment 72310 [details]
Rebaseline patch 3
Comment 6 Martin Robinson 2010-10-29 09:12:42 PDT 
Comment on attachment 72307 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72307&action=review

> WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:140
> +    g_object_set(settings, "gtk-xft-antialias", 1, "gtk-xft-hinting", 0, "gtk-font-name", "Liberation Sans 16", NULL);

I think I'd still prefer line breaks betwen all of the pairs here, just for consistency sake.
Comment 7 Martin Robinson 2010-10-29 09:28:21 PDT 
We just need to figure out how to land this without causing grief to everyone else.