Bug 48532 - Web Inspector: make legacy resource tracking optional in the native code, make cookeis work against new resource manager.
Summary: Web Inspector: make legacy resource tracking optional in the native code, mak...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 48557
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-28 10:21 PDT by Pavel Feldman
Modified: 2010-10-28 14:37 PDT (History)
14 users (show)

See Also:


Attachments
[PATCH] Proposed change. (41.88 KB, patch)
2010-10-28 10:37 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Same with js fixed. (42.74 KB, patch)
2010-10-28 10:48 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-28 10:21:38 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-10-28 10:37:50 PDT
Created attachment 72206 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-10-28 10:48:48 PDT
Created attachment 72207 [details]
[PATCH] Same with js fixed.
Comment 3 Pavel Feldman 2010-10-28 13:22:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/InspectorCSSStore.cpp
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/inspector/InspectorResource.h
	M	WebCore/inspector/InspectorResourceAgent.cpp
	M	WebCore/inspector/front-end/CookieItemsView.js
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/inspector.js
Committed r70800
Comment 4 WebKit Review Bot 2010-10-28 13:54:17 PDT
http://trac.webkit.org/changeset/70800 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/console-resource-errors.html
http/tests/inspector/console-xhr-logging.html
Comment 5 Ryosuke Niwa 2010-10-28 14:37:57 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/70800 might have broken SnowLeopard Intel Release (Tests)
> The following tests are not passing:
> http/tests/inspector/console-resource-errors.html
> http/tests/inspector/console-xhr-logging.html

This indeed seems to be the case.  Please investigate the failures.