Bug 48522 - fast/text/international/bidi-linebreak*.html Layout tests broken
Summary: fast/text/international/bidi-linebreak*.html Layout tests broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2010-10-28 07:08 PDT by Jeremy Moskovich
Modified: 2011-03-03 20:55 PST (History)
5 users (show)

See Also:

Attachments
Results of bidi-linebreak-001 on ToT . (16.91 KB, image/png)
2010-10-28 07:10 PDT, Jeremy Moskovich 		no flags Details
Patch (1.42 KB, patch)
2011-03-03 11:46 PST, Jeremy Moskovich 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2010-10-28 07:08:47 PDT 
bidi-linebreak-001.html, bidi-linebreak-002.html & bidi-linebreak-003.html have regressed on ToT.

Other browsers:
Safari 5.0.1: OK
WebKit nightly r70618: FAIL
Comment 1 Jeremy Moskovich 2010-10-28 07:10:18 PDT 
Created attachment 72186 [details]
Results of bidi-linebreak-001 on ToT .
Comment 2 mitz 2010-10-28 07:13:21 PDT 
I think this bug is invalid. Adam Barth can confirm. See r61234.
Comment 3 Jeremy Moskovich 2010-10-28 07:43:47 PDT 
Thanks for tracking that down Mitz.
Comment 4 Adam Barth 2010-10-28 10:39:10 PDT 
Yeah, this test doesn't test what it intends anymore because the HTML5 parser normalizes some of the whitespace to other characters.
Comment 5 Jeremy Moskovich 2010-10-28 10:57:07 PDT 
Does it make sense to remove or annotate the tests?
Comment 6 Adam Barth 2010-10-28 13:45:15 PDT 
Sure, that seems like a good idea.
Comment 7 Jeremy Moskovich 2011-03-03 11:45:17 PST 
Reopening so we can add some documentation on why the tests are failing.
Comment 8 Jeremy Moskovich 2011-03-03 11:46:03 PST 
Created attachment 84600 [details]
Patch
Comment 9 Dimitri Glazkov (Google) 2011-03-03 11:47:40 PST 
Comment on attachment 84600 [details]
Patch

k
Comment 10 WebKit Commit Bot 2011-03-03 20:53:35 PST 
The commit-queue encountered the following flaky tests while processing attachment 84600 [details]:

security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2011-03-03 20:55:39 PST 
Comment on attachment 84600 [details]
Patch

Clearing flags on attachment: 84600

Committed r80316: <http://trac.webkit.org/changeset/80316>
Comment 12 WebKit Commit Bot 2011-03-03 20:55:45 PST 
All reviewed patches have been landed.  Closing bug.