Bug 48505 – Change Noncopyable macro to avoid using two subsequent line

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Template Framework

[Zoltan Horvath]

With the actual WTF_MAKE_NONCOPYABLE and WTF_MAKE_FAST_ALLOCATED macro implementations when a class needs to be Noncopyable and FastAllocated as well we'd have needed to add 2 subsequent line 1-1 for each macro.
With this change we can use these in one line.

Examples:

In the case when Example is not instantiated by new and needs to be Noncopyable:
class Example {
    WTF_MAKE_NONCOPYABLE(Example);
};

In the case when Example is instantiated by new and needs to be Noncopyable:
class Example {
    WTF_MAKE_NONCOPYABLE(Example, WTF_MAKE_FAST_ALLOCATED);
};

[Zoltan Horvath]

Created attachment 72166 [details]
proposed patch

[Zoltan Horvath]

This is ping for review.

[Darin Adler]

Comment on attachment 72166 [details]
proposed patch

This doesn’t seem like an improvement to me. Just seems a bit strange. If we want to put things all on one line, we can do that without adding this unusual feature to the macro.
 
    WTF_MAKE_NONCOPYABLE(Example); WTF_MAKE_FAST_ALLOCATED;

I suggest not making this change.

[Zoltan Horvath]

Right! I close the bug as invalid.