RESOLVED FIXED 48504
Remove obsolete public/API methods in chromium port 
https://bugs.webkit.org/show_bug.cgi?id=48504
Summary Remove obsolete public/API methods in chromium port
Satish Sampath
Reported 2010-10-28 02:57:28 PDT
In http://trac.webkit.org/changeset/70567 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition.
Attachments
Patch (1.43 KB, patch)
2010-10-28 02:59 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-10-28 02:59:23 PDT
Created attachment 72165 [details] Patch
Steve Block
Comment 2 2010-10-28 03:10:23 PDT
Comment on attachment 72165 [details] Patch Is this correct? It looks like we've taken the implementation from the deprecated method.
Satish Sampath
Comment 3 2010-10-28 03:15:10 PDT
The method with 2 parameters is deprecated and WebKit currently calls the 3 parameter method. In chromium, the class implementing this interface only implements the 3 parameter variant. So the 2 parameter variant is no longer needed and is removed here.
Satish Sampath
Comment 4 2010-10-28 03:15:29 PDT
Pointer to the chromium class which implements this interface: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/speech_input_dispatcher.cc?revision=64213&view=markup
Steve Block
Comment 5 2010-10-28 05:35:45 PDT
Comment on attachment 72165 [details] Patch r=me
WebKit Commit Bot
Comment 6 2010-10-28 05:56:55 PDT
Comment on attachment 72165 [details] Patch Clearing flags on attachment: 72165 Committed r70769: <http://trac.webkit.org/changeset/70769>
WebKit Commit Bot
Comment 7 2010-10-28 05:57:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.