Bug 48504 - Remove obsolete public/API methods in chromium port
Summary: Remove obsolete public/API methods in chromium port
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-10-28 02:57 PDT by Satish Sampath
Modified: 2010-10-28 05:57 PDT (History)
2 users (show)

See Also:

Patch (1.43 KB, patch)
2010-10-28 02:59 PDT, Satish Sampath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-10-28 02:57:28 PDT
In http://trac.webkit.org/changeset/70567 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition.
Comment 1 Satish Sampath 2010-10-28 02:59:23 PDT
Created attachment 72165 [details]
Comment 2 Steve Block 2010-10-28 03:10:23 PDT
Comment on attachment 72165 [details]

Is this correct? It looks like we've taken the implementation from the deprecated method.
Comment 3 Satish Sampath 2010-10-28 03:15:10 PDT
The method with 2 parameters is deprecated and WebKit currently calls the 3 parameter method. In chromium, the class implementing this interface only implements the 3 parameter variant. So the 2 parameter variant is no longer needed and is removed here.
Comment 4 Satish Sampath 2010-10-28 03:15:29 PDT
Pointer to the chromium class which implements this interface: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/speech_input_dispatcher.cc?revision=64213&view=markup
Comment 5 Steve Block 2010-10-28 05:35:45 PDT
Comment on attachment 72165 [details]

Comment 6 WebKit Commit Bot 2010-10-28 05:56:55 PDT
Comment on attachment 72165 [details]

Clearing flags on attachment: 72165

Committed r70769: <http://trac.webkit.org/changeset/70769>
Comment 7 WebKit Commit Bot 2010-10-28 05:57:00 PDT
All reviewed patches have been landed.  Closing bug.