Bug 48496 – Add WebKit2 API for window feature getter/setters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Add WebKit2 API for window feature getter/setters

[Sam Weinig]

Created attachment 72133 [details]
Patch

[WebKit Review Bot]

Attachment 72133 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:172:  Extra space between WKPageGetToolbarsAreVisibleCallback and toolbarsAreVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:173:  Extra space between WKPageSetToolbarsAreVisibleCallback and setToolbarsAreVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:174:  Extra space between WKPageGetMenuBarIsVisibleCallback and menuBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:175:  Extra space between WKPageSetMenuBarIsVisibleCallback and setMenuBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:176:  Extra space between WKPageGetStatusBarIsVisibleCallback and statusBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:177:  Extra space between WKPageSetStatusBarIsVisibleCallback and setStatusBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:178:  Extra space between WKPageGetIsResizableCallback and isResizable  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:179:  Extra space between WKPageSetIsResizableCallback and setIsResizable  [whitespace/declaration] [3]
Total errors found: 8 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 72133 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4838052

[John Sullivan]

Comment on attachment 72133 [details]
Patch

There's a mixture of naming styles here, e.g.:

WebChromeClient: setMenubarVisible/menubarVisible
WebUIClient: setMenuBarIsVisible/menuBarIsVisible
MiniBrowser/TestController: setMenuBarVisible/getMenuBarVisible

The AppKit conventions that we generally try to match are none of the above -- those conventions would specify: setMenuBarVisible (or setMenubarVisible) / isMenuBarVisible (or isMenubarVisible).

I don't care whether the B in Menubar is capitalized or not, but we should try to match existing style in WebKit if there are precedents. Of the other styles, I would pick the AppKit style, but if there's some reason to use a different style then we should use it consistently.

The content all seems fine but I think we need to get the names more consistent so I'm giving this an r-.


 In WebChromeClient you' MiniBrowser you're using getMenuBarVisible/setMenuBarVisible (etc.) whereas in WebUIClient you're using getMenuBarIsVisible/setMenuBarIsVisible

[Sam Weinig]

Created attachment 72210 [details]
Updated.

This fixes the tools to match the names in WebKit2, but does not change ChromeClient, as that is WebCore internal.

[WebKit Review Bot]

Attachment 72210 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:172:  Extra space between WKPageGetToolbarsAreVisibleCallback and toolbarsAreVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:173:  Extra space between WKPageSetToolbarsAreVisibleCallback and setToolbarsAreVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:174:  Extra space between WKPageGetMenuBarIsVisibleCallback and menuBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:175:  Extra space between WKPageSetMenuBarIsVisibleCallback and setMenuBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:176:  Extra space between WKPageGetStatusBarIsVisibleCallback and statusBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:177:  Extra space between WKPageSetStatusBarIsVisibleCallback and setStatusBarIsVisible  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:178:  Extra space between WKPageGetIsResizableCallback and isResizable  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:179:  Extra space between WKPageSetIsResizableCallback and setIsResizable  [whitespace/declaration] [3]
Total errors found: 8 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Landed in r70790.