WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48492
Remove unused proxied panel interface
https://bugs.webkit.org/show_bug.cgi?id=48492
Summary
Remove unused proxied panel interface
Ivan Krstić
Reported
2010-10-27 18:59:55 PDT
Remove unused proxied panel interface for <
rdar://problem/7237059
>.
Attachments
removes unused proxied panel interface
(19.76 KB, patch)
2010-10-27 19:00 PDT
,
Ivan Krstić
mrowe
: review-
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
fix WKSyncSurfaceToView removal
(19.48 KB, patch)
2010-10-27 21:53 PDT
,
Ivan Krstić
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ivan Krstić
Comment 1
2010-10-27 19:00:46 PDT
Created
attachment 72128
[details]
removes unused proxied panel interface
WebKit Commit Bot
Comment 2
2010-10-27 20:44:06 PDT
Comment on
attachment 72128
[details]
removes unused proxied panel interface Rejecting patch 72128 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: WebKit.build/Script-5D88EE6C11407DE800BC3ABC.sh ** BUILD FAILED ** The following build commands failed: WebKit: CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebHostedNetscapePluginView.o /Projects/CommitQueue/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 (1 failure) Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81. Full output:
http://queues.webkit.org/results/4768051
Mark Rowe (bdash)
Comment 3
2010-10-27 20:57:18 PDT
Comment on
attachment 72128
[details]
removes unused proxied panel interface View in context:
https://bugs.webkit.org/attachment.cgi?id=72128&action=review
> WebKitLibraries/WebKitSystemInterface.h:-322 > -void WKSyncSurfaceToView(NSView *view);
Looks like you removed too much here. Please fix this and upload a new patch.
Ivan Krstić
Comment 4
2010-10-27 21:53:25 PDT
Created
attachment 72141
[details]
fix WKSyncSurfaceToView removal
WebKit Commit Bot
Comment 5
2010-10-28 00:13:09 PDT
The commit-queue encountered the following flaky tests while processing
attachment 72141
[details]
: fast/workers/storage/interrupt-database-sync.html Please file bugs against the tests. These tests were authored by
dumi@chromium.org
. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6
2010-10-28 00:14:56 PDT
Comment on
attachment 72141
[details]
fix WKSyncSurfaceToView removal Clearing flags on attachment: 72141 Committed
r70751
: <
http://trac.webkit.org/changeset/70751
>
WebKit Commit Bot
Comment 7
2010-10-28 00:15:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug