Bug 4849 - htmltokenizer.cpp won't compile with TOKEN_DEBUG defined
Summary: htmltokenizer.cpp won't compile with TOKEN_DEBUG defined
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All OS X 10.4
: P2 Trivial
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-04 13:10 PDT by Alexey Proskuryakov
Modified: 2005-09-20 10:10 PDT (History)
0 users

See Also:


Attachments
proposed patch (3.58 KB, patch)
2005-09-04 13:11 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2005-09-04 13:10:36 PDT
Several fixes to make it compile cleanly in debug mode (I'm using a locally modified KWQKDebug.h that 
actually prints something).
Comment 1 Alexey Proskuryakov 2005-09-04 13:11:18 PDT
Created attachment 3759 [details]
proposed patch
Comment 2 Oliver Hunt 2005-09-07 03:56:18 PDT
Mark the patch for review
Comment 3 Darin Adler 2005-09-07 08:19:39 PDT
Comment on attachment 3759 [details]
proposed patch

It's really ugly that this includes calls to operator->, and the string is not
guaranteed to be contiguous, so it won't always work.

But on the other hand, at least it compiles. Maybe later we'll just remove all
this code.

r=me