Bug 48488 – [chromium] add a master-name flag to new-run-webkit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

[chromium] add a master-name flag to new-run-webkit-tests

[Ojan Vafai]

Created attachment 72120 [details]
Patch

[Dirk Pranke]

Comment on attachment 72120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72120&action=review

LGTM with the minor comment about the FIXME (I don't feel strongly about it one way or another).

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958
> +

Is there a reason you didn't just add

if not self._options.test_results_server:
    raise AssertionError()

or something here instead of adding a FIXME?

[Tony Chang]

Comment on attachment 72120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72120&action=review

>> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958
>> +
> 
> Is there a reason you didn't just add
> 
> if not self._options.test_results_server:
>     raise AssertionError()
> 
> or something here instead of adding a FIXME?

I assume we need to add the flags to the bots, which is a server change?  I guess we could do that first.  Once we require it, we can unit tests this requirement.

Seems fine for now.

[Ojan Vafai]

(In reply to comment #3)
> >> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958
> > 
> > Is there a reason you didn't just add
> > 
> > if not self._options.test_results_server:
> >     raise AssertionError()
> > 
> > or something here instead of adding a FIXME?
> 
> I assume we need to add the flags to the bots, which is a server change?  I guess we could do that first.  Once we require it, we can unit tests this requirement.

Right. The bots need to add the flag. But in order to add the flag to the bots, the script needs to allow the flag in the first place.

[Ojan Vafai]

Committed r70782: <http://trac.webkit.org/changeset/70782>