Bug 48478 – [chromium] Make the test results server store which master the bot is on

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

[chromium] Make the test results server store which master the bot is on

[Ojan Vafai]

Created attachment 72100 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 72100 [details]
Patch

ok

[Victor Wang]

Comment on attachment 72100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review

> WebKitTools/TestResultServer/model/testfile.py:103
>          if not files:

Fill in the missing master/test_type here?
if not test_type:
    test_type = "layout-tests"

[Ojan Vafai]

Comment on attachment 72100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review

>> WebKitTools/TestResultServer/model/testfile.py:103
>>          if not files:
> 
> Fill in the missing master/test_type here?
> if not test_type:
>     test_type = "layout-tests"

my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere.

[Victor Wang]

(In reply to comment #4)
> (From update of attachment 72100 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review
> 
> >> WebKitTools/TestResultServer/model/testfile.py:103
> >>          if not files:
> > 
> > Fill in the missing master/test_type here?
> > if not test_type:
> >     test_type = "layout-tests"
> 
> my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere.

Sounds good then. Thanks for making the change!

[Ojan Vafai]

Committed r70724: <http://trac.webkit.org/changeset/70724>

[WebKit Review Bot]

http://trac.webkit.org/changeset/70724 might have broken GTK Linux 32-bit Release