Bug 48478 - [chromium] Make the test results server store which master the bot is on
Summary: [chromium] Make the test results server store which master the bot is on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 15:47 PDT by Ojan Vafai
Modified: 2010-10-27 18:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (16.43 KB, patch)
2010-10-27 15:49 PDT, Ojan Vafai 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-10-27 15:47:05 PDT 
[chromium] Make the test results server store which master the bot is on
Comment 1 Ojan Vafai 2010-10-27 15:49:40 PDT 
Created attachment 72100 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-10-27 15:56:15 PDT 
Comment on attachment 72100 [details]
Patch

ok
Comment 3 Victor Wang 2010-10-27 16:11:56 PDT 
Comment on attachment 72100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review

> WebKitTools/TestResultServer/model/testfile.py:103
>          if not files:

Fill in the missing master/test_type here?
if not test_type:
    test_type = "layout-tests"
Comment 4 Ojan Vafai 2010-10-27 16:22:52 PDT 
Comment on attachment 72100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review

>> WebKitTools/TestResultServer/model/testfile.py:103
>>          if not files:
> 
> Fill in the missing master/test_type here?
> if not test_type:
>     test_type = "layout-tests"

my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere.
Comment 5 Victor Wang 2010-10-27 16:25:51 PDT 
(In reply to comment #4)
> (From update of attachment 72100 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review
> 
> >> WebKitTools/TestResultServer/model/testfile.py:103
> >>          if not files:
> > 
> > Fill in the missing master/test_type here?
> > if not test_type:
> >     test_type = "layout-tests"
> 
> my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere.

Sounds good then. Thanks for making the change!
Comment 6 Ojan Vafai 2010-10-27 16:33:39 PDT 
Committed r70724: <http://trac.webkit.org/changeset/70724>
Comment 7 WebKit Review Bot 2010-10-27 18:57:34 PDT 
http://trac.webkit.org/changeset/70724 might have broken GTK Linux 32-bit Release