Bug 48445 - [GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
Summary: [GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-10-27 11:21 PDT by Martin Robinson
Modified: 2010-10-27 11:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch for this issue (3.73 KB, patch)
2010-10-27 11:27 PDT, Martin Robinson
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-27 11:21:44 PDT
r69296 includes a cast from GdkWindow* to GtkWindow*. This is causing a crash in plugins/null-npp-getvalue-pointer.html.
Comment 1 Martin Robinson 2010-10-27 11:27:51 PDT
Created attachment 72059 [details]
Patch for this issue
Comment 2 Gustavo Noronha (kov) 2010-10-27 11:31:15 PDT
Comment on attachment 72059 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=72059&action=review

> WebCore/ChangeLog:10
> +        GdkWindow*. The widget is used to get the proper visual for the
> +        widget.

"The widget is used to get the proper visual for the widget." sounds really weird. Perhaps "for the plugin's container widget"? Otherwise looks right!
Comment 3 Martin Robinson 2010-10-27 11:39:06 PDT
Committed r70677: <http://trac.webkit.org/changeset/70677>