Bug 48444 – Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox.  They're hardcoded to assume horizontal-tb writing-mode right now.

[Dave Hyatt]

Created attachment 72376 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 72376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72376&action=review

> WebCore/rendering/RenderBox.h:382
> +    int convertFromFlippedWritingMode(int);

I think a parameter name here would be helpful.

Should this instead have a name like "convertFromLogicalToPhysicalVerticalPosition" or just "toPhysicalVerticalPosition"?

> WebCore/rendering/RenderLineBoxList.cpp:173
> +bool RenderLineBoxList::anyLinesIntersectDirtyRect(RenderBoxModelObject* renderer, const PaintInfo& paintInfo, int tx, int ty, bool usePrintRect) const

I might have moved the "s" from "Lines" to "Intersect": anyLineIntersectsDirtyRect.

> WebCore/rendering/RenderLineBoxList.h:74
>  private:
> +    bool anyLinesIntersectDirtyRect(RenderBoxModelObject*, const PaintInfo&, int x, int y, bool usePrintRect) const;
> +    bool lineIntersectsDirtyRect(RenderBoxModelObject*, InlineFlowBox*, const PaintInfo&, int x, int y) const;
> +    bool rangeIntersectsDirtyRect(RenderBoxModelObject*, int logicalTop, int logicalBottom, const PaintInfo&, int x, int y) const;
> +
> +private:

What's with the double private:?

[Dave Hyatt]

Fixed in r70917.

[Dmitry Titov]

This seem to brake image compare for fast/blockflow/english-rl-text.html.

To repro, run this on post-70917 WebKit, nac build:
run-webkit-tests -p LayoutTests/fast/blockflow/english-rl-text.html

I'll attach 2 images in a second.

[Dmitry Titov]

Created attachment 72403 [details]
Platform/mac image (expected)

[Dmitry Titov]

Created attachment 72405 [details]
Actual file as DRT produces