Bug 48433 - Crash in NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in WebKit2 on Windows
Summary: Crash in NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-10-27 08:54 PDT by Adam Roben (:aroben)
Modified: 2010-10-27 09:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.84 KB, patch)
2010-10-27 08:55 PDT, Adam Roben (:aroben) 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-27 08:54:04 PDT 
Crash in NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in WebKit2 on Windows
Comment 1 Adam Roben (:aroben) 2010-10-27 08:55:33 PDT 
Created attachment 72040 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-10-27 08:56:34 PDT 
<rdar://problem/8483196>
Comment 3 WebKit Review Bot 2010-10-27 08:57:55 PDT 
Attachment 72040 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:54:  NullNPPGetValuePointer::NPP_GetValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2010-10-27 09:09:33 PDT 
Committed r70653: <http://trac.webkit.org/changeset/70653>