Bug 48422 – [GTK] Use sentence boundaries instead of start/end sentence

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

From pango docs:

/* There are two ways to divide sentences. The first assigns all
   * intersentence whitespace/control/format chars to some sentence,
   * so all chars are in some sentence; is_sentence_boundary denotes
   * the boundaries there. The second way doesn't assign
   * between-sentence spaces, etc. to any sentence, so
   * is_sentence_start/is_sentence_end mark the boundaries of those
   * sentences.
   */

ICU seems to use the first way while TextBreakIteratorGtk uses the second one. We should use is_sentence_boundary in TextBreakIteratorGtk to get the same results that ICU.

[Carlos Garcia Campos]

Created attachment 72023 [details]
Patch

It fixes test fast/dom/Range/range-expand.html, actually it doesn't pass, but sentence tests don't fail, only Chinese word tests are failing because of pango bug https://bugzilla.gnome.org/show_bug.cgi?id=97545

[Martin Robinson]

Comment on attachment 72023 [details]
Patch

Great.

[WebKit Commit Bot]

Comment on attachment 72023 [details]
Patch

Rejecting patch 72023 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72023]" exit_code: 2
Last 500 characters of output:
 u'Martin Robinson', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp
Hunk #1 FAILED at 300.
Hunk #2 FAILED at 315.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp.rej

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4775046

[Carlos Garcia Campos]

Comment on attachment 72023 [details]
Patch

It should apply now

[WebKit Commit Bot]

Comment on attachment 72023 [details]
Patch

Clearing flags on attachment: 72023

Committed r71296: <http://trac.webkit.org/changeset/71296>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.