RESOLVED FIXED 48405
[Windows] Textfields <input>s have different widths
https://bugs.webkit.org/show_bug.cgi?id=48405
Summary [Windows] Textfields <input>s have different widths
Kent Tamura
Reported 2010-10-27 02:57:58 PDT
Created attachment 71999 [details] Test case Windows-only (including Chromium-win). http://crbug.com/60348 shows three different issues. - type=search appearance is almost same as type=text on Windows, but its width is shorter. Probably this is intentional. An older revision of RenderThemeWin.cpp had the following comment: // Override padding size to match AppKit text positioning. # http://trac.webkit.org/changeset/42020/trunk/WebCore/rendering/RenderThemeWin.cpp - type=color/email/tel/url is shorter because they don't have "padding:1px 0" in themeWin.css. - Input types with spin-button is shorter. The root cause is unknown yet.
Attachments
Test case (1.18 KB, text/html)
2010-10-27 02:57 PDT, Kent Tamura
no flags
Patch (2.65 KB, patch)
2010-10-28 02:41 PDT, Kent Tamura
no flags
Patch 2 (7.91 KB, patch)
2010-12-13 16:45 PST, Kent Tamura
no flags
Patch 3 (8.01 KB, patch)
2011-01-24 01:34 PST, Kent Tamura
no flags
Tony Chang
Comment 1 2010-10-27 10:05:54 PDT
I think they're supposed to match the size of inputs in IE for web compatibility. Ojan knows the details.
Kent Tamura
Comment 2 2010-10-28 02:40:26 PDT
(In reply to comment #1) > I think they're supposed to match the size of inputs in IE for web compatibility. Ojan knows the details. It's the reason why type=text on WebKit/Windows is different from WebKit/Mac, isn't it? Anyway, non-search text field types should have same widths with type=text.
Kent Tamura
Comment 3 2010-10-28 02:41:05 PDT
Kent Tamura
Comment 4 2010-10-28 02:41:58 PDT
(In reply to comment #3) > Created an attachment (id=72163) [details] > Patch This patch will break some rendering tests. I'll take care of them when I commit the patch.
Kent Tamura
Comment 5 2010-10-28 04:13:00 PDT
(In reply to comment #3) > Created an attachment (id=72163) [details] > Patch It won't change type=search width.
Brian Weinstein
Comment 6 2010-11-22 10:47:15 PST
Comment on attachment 72163 [details] Patch Which tests is this covered by? Will tests need to be rebaselined? Because if they are passing now, won't this change break them?
Brian Weinstein
Comment 7 2010-11-22 10:47:50 PST
(In reply to comment #6) > (From update of attachment 72163 [details]) > Which tests is this covered by? Will tests need to be rebaselined? Because if they are passing now, won't this change break them? Oh, saw your comment above, sorry for the noise.
Kent Tamura
Comment 8 2010-11-24 23:13:19 PST
Probably, only fast/forms/input-appearance-spinbutton-disabled-readonly.html will be affected.
Adam Roben (:aroben)
Comment 9 2010-11-29 06:40:49 PST
(In reply to comment #8) > Probably, only fast/forms/input-appearance-spinbutton-disabled-readonly.html will be affected. If that is the case, it sounds like we need more new tests that check the width of the other input types.
Eric Seidel (no email)
Comment 10 2010-12-12 02:38:41 PST
Yes, this is very much an Ojan question.
Kent Tamura
Comment 11 2010-12-13 15:55:22 PST
Comment on attachment 72163 [details] Patch Withdrawn. I'll add new test.
Kent Tamura
Comment 12 2010-12-13 16:45:01 PST
Created attachment 76467 [details] Patch 2
Kent Tamura
Comment 13 2011-01-24 01:34:16 PST
Created attachment 79901 [details] Patch 3 rebased
Dimitri Glazkov (Google)
Comment 14 2011-01-24 07:05:59 PST
Comment on attachment 79901 [details] Patch 3 ok.
Kent Tamura
Comment 15 2011-01-24 20:38:39 PST
Comment on attachment 79901 [details] Patch 3 Clearing flags on attachment: 79901 Committed r76567: <http://trac.webkit.org/changeset/76567>
Kent Tamura
Comment 16 2011-01-24 20:38:48 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 17 2011-01-24 21:47:18 PST
http://trac.webkit.org/changeset/76567 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.