Bug 48401 - [Qt] Type mismatch while serializing/deserializing message id size
Summary: [Qt] Type mismatch while serializing/deserializing message id size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 00:14 PDT by Kimmo Kinnunen
Modified: 2010-10-27 14:03 PDT (History)
4 users (show)

See Also:


Attachments
use same type for sizeof() while reading and writing (1.65 KB, patch)
2010-10-27 00:19 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2010-10-27 00:14:42 PDT
In WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp, size of the sent buffer is calculated in two ways:
 1) sizeof(uint32_t) when writing
 2) sizeof(MessageId) when reading

This doesn't cause problems at the moment, but might cause them later (or on some obscure compilers).
Comment 1 Kimmo Kinnunen 2010-10-27 00:19:49 PDT
Created attachment 71993 [details]
use same type for sizeof() while reading and writing
Comment 2 Andreas Kling 2010-10-27 02:59:51 PDT
Comment on attachment 71993 [details]
use same type for sizeof() while reading and writing

LGTM.
Comment 3 WebKit Commit Bot 2010-10-27 04:48:34 PDT
Comment on attachment 71993 [details]
use same type for sizeof() while reading and writing

Clearing flags on attachment: 71993

Committed r70635: <http://trac.webkit.org/changeset/70635>
Comment 4 WebKit Commit Bot 2010-10-27 04:48:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-10-27 14:03:09 PDT
http://trac.webkit.org/changeset/70635 might have broken GTK Linux 32-bit Release