Bug 48390 – WebKit2 geolocation permission request

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Luiz Agostini]

Geolocation permission requests must be sent to the UIProcess to be submitted to the user.

[Luiz Agostini]

Created attachment 71971 [details]
patch

[Luiz Agostini]

ping review

[WebKit Review Bot]

Attachment 71971 [details] did not build on win:
Build output: http://queues.webkit.org/results/4839104

[Kenneth Rohde Christiansen]

Comment on attachment 71971 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71971&action=review

> WebCore/page/Geolocation.cpp:216
> +static uint64_t generateId()

it seems more to be incrementing an id than really generating one. But maybe that is ok.

> WebKit2/UIProcess/WebPageProxy.cpp:1246
> +    process()->connection()->send(Messages::WebProcess::SetGelocationPermission(requestID, result), 0);

shouldn't this just be send( and not process()->connection()->send ? That should work on trunk

> WebKit2/UIProcess/WebPageProxy.h:301
> +    // Geolocation permission

dot at the end of comments

> WebKit2/UIProcess/WebPageProxy.messages.in:104
> +    # Geolocation permissions

here as well

> WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:472
> +    WebFrame* webFrame =  static_cast<WebFrameLoaderClient*>(frame->loader()->client())->webFrame();

extra space infront of the statuc cast, remove

> WebKit2/WebProcess/WebProcess.h:87
> +    void setGelocationPermission(uint64_t, bool);

Spelling error here! Gelocation, it is called Geolocation

> WebKit2/WebProcess/WebProcess.messages.in:46
> +    # Geolocation permissions

dot at end of comments

[Sam Weinig]

Comment on attachment 71971 [details]
patch

Thus far we have gotten away without adding IDs to WebCore objects and I would like to try and keep it that way.  We should instead use an external hash table.