WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48388
Add DownloadManager class
https://bugs.webkit.org/show_bug.cgi?id=48388
Summary
Add DownloadManager class
Anders Carlsson
Reported
2010-10-26 16:18:42 PDT
Add DownloadManager class
Attachments
Patch
(15.58 KB, patch)
2010-10-26 16:21 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(15.58 KB, patch)
2010-10-26 16:35 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-10-26 16:21:01 PDT
Created
attachment 71960
[details]
Patch
WebKit Review Bot
Comment 2
2010-10-26 16:24:13 PDT
Attachment 71960
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Downloads/DownloadManager.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3
2010-10-26 16:34:18 PDT
Attachment 71960
[details]
did not build on qt: Build output:
http://queues.webkit.org/results/4847028
Anders Carlsson
Comment 4
2010-10-26 16:35:53 PDT
Created
attachment 71962
[details]
Patch
WebKit Review Bot
Comment 5
2010-10-26 16:40:15 PDT
Attachment 71962
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Downloads/DownloadManager.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 6
2010-10-27 10:01:22 PDT
Committed
r70659
: <
http://trac.webkit.org/changeset/70659
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug