Bug 48383 - [CHROMIUM] Add new baselines for canvas tests running on the GPU.
Summary: [CHROMIUM] Add new baselines for canvas tests running on the GPU.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 15:17 PDT by Stephen White
Modified: 2010-10-26 16:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (998.17 KB, patch)
2010-10-26 15:18 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch for this issue (766.83 KB, text/plain)
2010-10-26 16:16 PDT, Martin Robinson 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-10-26 15:17:56 PDT 
Add new baselines for canvas tests running on the GPU.
Comment 1 Stephen White 2010-10-26 15:18:58 PDT 
Created attachment 71949 [details]
Patch
Comment 2 Kenneth Russell 2010-10-26 15:40:09 PDT 
Comment on attachment 71949 [details]
Patch

It turns out you don't need review for committing new baselines. Just say something like "Unreviewed, test expectations update". Rubber-stamping because I know you've investigated the correctness of these baselines and have already filed bugs about outstanding issues.
Comment 3 Stephen White 2010-10-26 15:42:09 PDT 
(In reply to comment #2)
> (From update of attachment 71949 [details])
> It turns out you don't need review for committing new baselines. Just say something like "Unreviewed, test expectations update". Rubber-stamping because I know you've investigated the correctness of these baselines and have already filed bugs about outstanding issues.

Thanks.  I'm aware of the rubberstamp policy; I mostly wanted to give you a chance to look at the test_expectations change (since it's pretty major).

Other than that, you're right; there's not much point in looking at the images.
Comment 4 Stephen White 2010-10-26 15:54:08 PDT 
Committed r70582: <http://trac.webkit.org/changeset/70582>
Comment 5 Martin Robinson 2010-10-26 16:16:18 PDT 
Created attachment 71958 [details]
Patch for this issue
Comment 6 Martin Robinson 2010-10-26 16:17:06 PDT 
Sorry. It appears as though webkit-patch chose the wrong bug for my patch.