RESOLVED FIXED 48376
Web Inspector: make debugger work against new resource manager. 
https://bugs.webkit.org/show_bug.cgi?id=48376
Summary Web Inspector: make debugger work against new resource manager.
Pavel Feldman
Reported 2010-10-26 14:37:49 PDT
Currently "resource - url" binding is happening too late in resourceManager's case.
Attachments
[PATCH] Proposed change. (23.90 KB, patch)
2010-10-27 07:46 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Same with the style fixed. (23.88 KB, patch)
2010-10-27 11:40 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-10-27 07:46:21 PDT
Created attachment 72034 [details] [PATCH] Proposed change. This makes debugger happy + makes all tests pass in the resourceManager mode (by the resource tracking's full path modulus).
WebKit Review Bot
Comment 2 2010-10-27 07:49:21 PDT
Attachment 72034 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/inspector/front-end/networkPanel.css:423: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 3 2010-10-27 11:40:03 PDT
Created attachment 72063 [details] [PATCH] Same with the style fixed.
Timothy Hatcher
Comment 4 2010-10-27 11:44:47 PDT
Comment on attachment 72063 [details] [PATCH] Same with the style fixed. View in context: https://bugs.webkit.org/attachment.cgi?id=72063&action=review > WebCore/inspector/front-end/ResourceManager.js:398 > + this._resourcesByURL[resource.url] = [ resourceForURL ]; No spaces should be inside the brackets.
Pavel Feldman
Comment 5 2010-10-28 03:23:33 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/inspector-test2.js M LayoutTests/http/tests/inspector/resource-har-conversion.html M LayoutTests/http/tests/inspector/resource-parameters.html M LayoutTests/inspector/extensions-resources.html M WebCore/ChangeLog M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorResourceAgent.cpp M WebCore/inspector/InspectorResourceAgent.h M WebCore/inspector/front-end/ExtensionServer.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/StoragePanel.js M WebCore/inspector/front-end/networkPanel.css Committed r70762
Note You need to log in before you can comment on or make changes to this bug.