Bug 48362 - GTK: Update resource tracking when moving a frame between documents
Summary: GTK: Update resource tracking when moving a frame between documents
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Jenn Braithwaite
Depends on: 44713
  Show dependency treegraph
Reported: 2010-10-26 12:31 PDT by Jenn Braithwaite
Modified: 2010-11-01 18:36 PDT (History)
3 users (show)

See Also:

patch (3.33 KB, patch)
2010-10-26 16:33 PDT, Jenn Braithwaite
mrobinson: review-
Details | Formatted Diff | Diff
updated patch to fix style issue (3.32 KB, patch)
2010-10-27 10:11 PDT, Jenn Braithwaite
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jenn Braithwaite 2010-10-26 12:31:36 PDT
GTK fix for bug reported in 44713.  That patch provides the framework for the fix and fixes the Mac platform.  Separate patches will be submitted for other platforms, thus this separate bug.
Comment 1 Jenn Braithwaite 2010-10-26 16:33:11 PDT
Created attachment 71961 [details]

This patch does not add ASSERTs in FrameLoaderClient::dispatchDid{Finish/Fail}Loading to ensure that the test case for bug 44713 would fail without this fix, because there are comments allowing that a resource may not always be found by webkit_web_view_get_resource().  However, to test this change, I did put in the ASSERTs locally to verify the test crashes without the fix, and passes with the fix.
Comment 2 Martin Robinson 2010-10-27 00:28:34 PDT
Comment on attachment 71961 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=71961&action=review

Looks great. Thanks for fixing this for GTK+. There is one small style issue.

> WebKit/gtk/webkit/webkitwebview.cpp:4584
> +    } else {
> +      g_hash_table_remove(priv->subResources.get(), identifier);
> +    }

I think that WebKit style requires this last block to go without the curly braces (since it's only one line).
Comment 3 Jenn Braithwaite 2010-10-27 10:11:08 PDT
Created attachment 72051 [details]
updated patch to fix style issue
Comment 4 Martin Robinson 2010-11-01 09:08:27 PDT
Comment on attachment 72051 [details]
updated patch to fix style issue

Looks sane to me.
Comment 5 WebKit Commit Bot 2010-11-01 18:36:07 PDT
The commit-queue encountered the following flaky tests while processing attachment 72051 [details]:


Please file bugs against the tests.  These tests were authored by ap@webkit.org.  The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-11-01 18:36:53 PDT
Comment on attachment 72051 [details]
updated patch to fix style issue

Clearing flags on attachment: 72051

Committed r71090: <http://trac.webkit.org/changeset/71090>
Comment 7 WebKit Commit Bot 2010-11-01 18:36:59 PDT
All reviewed patches have been landed.  Closing bug.