Bug 48342 - Fix and cleanup of build systems
Summary: Fix and cleanup of build systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 10:33 PDT by Csaba Osztrogonác
Modified: 2010-10-29 09:27 PDT (History)
7 users (show)

See Also:


Attachments
proposed fix (18.84 KB, patch)
2010-10-26 10:48 PDT, Csaba Osztrogonác
ddkilzer: review-
Details | Formatted Diff | Diff
proposed fix v2 (23.79 KB, patch)
2010-10-27 15:57 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed fix v2 (1.25 KB, patch)
2010-10-27 16:15 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed fix v3 (24.38 KB, patch)
2010-10-27 16:17 PDT, Csaba Osztrogonác
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-10-26 10:33:45 PDT
There are some trivial issue. Details are in the patch.
Comment 1 Csaba Osztrogonác 2010-10-26 10:48:31 PDT
Created attachment 71907 [details]
proposed fix

- Remove all ENABLE_SANDBOX from build systems, because
we don't need it anymore after http://trac.webkit.org/changeset/69038

- Add missing features to Windows build system
Comment 2 Csaba Osztrogonác 2010-10-26 10:52:38 PDT
Comment on attachment 71907 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review

> WebKitTools/Scripts/build-webkit:-200
> -      define => "ENABLE_SANDBOX", default => 1, value => \$sandboxSupport },

I missed to remove unnecessary $sandboxSupport variable. I'm going to do it before landing.
Comment 3 Csaba Osztrogonác 2010-10-26 10:58:30 PDT
Comment on attachment 71907 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review

> WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:158
> +  <UserMacro
> +		Name="ENABLE_RUBY"
> +		Value="ENABLE_RUBY"
> +		PerformEnvironmentSet="true"
> +	/>

I'm not sure if it is correct for Cairo port.
What is your opinion?
Comment 4 David Kilzer (:ddkilzer) 2010-10-26 11:50:45 PDT
Comment on attachment 71907 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review

r- to fix the FeatureDefines.xcconfig files.  (Note that I only reviewed build-webkit and the Apple Xcode config files.)

> WebKit/mac/Configurations/FeatureDefines.xcconfig:-99
> -

Note that JavaScriptCore/Configurations/FeatureDefines.xcconfig should be exactly the same as WebCore/Configurations/FeatureDefines.xcconfig, WebKit/mac/Configurations/Configurations/FeatureDefines.xcconfig and WebKit2/Configurations/FeatureDefines.xcconfig.

It appears that ENABLE_FULLSCREEN_API is missing from all but JavaScriptCore's configuration file, and that WebKit2/Configurations/FeatureDefines.xcconfig is missing ENABLE_ACCELERATED_2D_CANVAS.

Thus I would copy JavaScriptCore/Configurations/FeatureDefines.xcconfig to replace all the other FeatureDefines.xcconfig files.

> WebKitTools/Scripts/build-webkit:-201
> -

The build-webkit script also appears to be missing ENABLE_FULLSCREEN_API support as well.
Comment 5 Csaba Osztrogonác 2010-10-27 15:57:42 PDT
Created attachment 72103 [details]
proposed fix v2
Comment 6 Csaba Osztrogonác 2010-10-27 16:02:08 PDT
(In reply to comment #5)
> Created an attachment (id=72103) [details]
> proposed fix v2

- Now the 4 xcconfig is exactly same.
- I removed unnecessary variable from build-webkit
- I added ENABLE_FULLSCREEN_API support to build-webkit
  (It is enabled only if isAppleMacWebKit() is true)
- I'm sure ENABLE_RUBY should be enabled in WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
Comment 7 Csaba Osztrogonác 2010-10-27 16:05:20 PDT
Comment on attachment 72103 [details]
proposed fix v2

http://trac.webkit.org/changeset/70722 killed me. 
with adding ENABLE_WEB_AUDIO support :((

I'll update the patch and upload again.
Comment 8 Csaba Osztrogonác 2010-10-27 16:15:03 PDT
Created attachment 72106 [details]
proposed fix v2

Updated to Tot and added ENABLE_WEB_AUDIO to *vsprops
Comment 9 Csaba Osztrogonác 2010-10-27 16:15:52 PDT
Comment on attachment 72106 [details]
proposed fix v2

bad patch, ooops
Comment 10 Csaba Osztrogonác 2010-10-27 16:17:47 PDT
Created attachment 72107 [details]
 proposed fix v3
Comment 11 David Kilzer (:ddkilzer) 2010-10-27 16:33:49 PDT
Comment on attachment 72107 [details]
 proposed fix v3

r=me for the FeatureDefines.xcconfig and build-webkit changes.  I can't really speak for the other changes.
Comment 12 David Kilzer (:ddkilzer) 2010-10-27 16:34:46 PDT
CCing Brent Fulgham to review the WinCairo vsprops changes.
Comment 13 Adam Roben (:aroben) 2010-10-28 05:23:59 PDT
Comment on attachment 72107 [details]
 proposed fix v3

r=me on the .vsprops changes. Thanks for doing this!
Comment 14 Csaba Osztrogonác 2010-10-28 05:38:05 PDT
David reviewed FeatureDefines.xcconfig and build-webkit 
changes, and Adam reviewed .vsprops changes.

I only need a review for removing unnecessary ENABLE_SANDBOX 
from all build systems. It is so simple.

David or Adam? r?
Comment 15 Csaba Osztrogonác 2010-10-29 08:28:39 PDT
(In reply to comment #10)
> Created an attachment (id=72107) [details]
>  proposed fix v3

Landed in http://trac.webkit.org/changeset/70878 .

ENABLE_METER is enabled in FeatureDefine*.vsprops, 
because turned of ENABLE_METER cause tests to fail. 
(rs=aroben for this modification on #webkit)