There are some trivial issue. Details are in the patch.
Created attachment 71907 [details] proposed fix - Remove all ENABLE_SANDBOX from build systems, because we don't need it anymore after http://trac.webkit.org/changeset/69038 - Add missing features to Windows build system
Comment on attachment 71907 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review > WebKitTools/Scripts/build-webkit:-200 > - define => "ENABLE_SANDBOX", default => 1, value => \$sandboxSupport }, I missed to remove unnecessary $sandboxSupport variable. I'm going to do it before landing.
Comment on attachment 71907 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:158 > + <UserMacro > + Name="ENABLE_RUBY" > + Value="ENABLE_RUBY" > + PerformEnvironmentSet="true" > + /> I'm not sure if it is correct for Cairo port. What is your opinion?
Comment on attachment 71907 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review r- to fix the FeatureDefines.xcconfig files. (Note that I only reviewed build-webkit and the Apple Xcode config files.) > WebKit/mac/Configurations/FeatureDefines.xcconfig:-99 > - Note that JavaScriptCore/Configurations/FeatureDefines.xcconfig should be exactly the same as WebCore/Configurations/FeatureDefines.xcconfig, WebKit/mac/Configurations/Configurations/FeatureDefines.xcconfig and WebKit2/Configurations/FeatureDefines.xcconfig. It appears that ENABLE_FULLSCREEN_API is missing from all but JavaScriptCore's configuration file, and that WebKit2/Configurations/FeatureDefines.xcconfig is missing ENABLE_ACCELERATED_2D_CANVAS. Thus I would copy JavaScriptCore/Configurations/FeatureDefines.xcconfig to replace all the other FeatureDefines.xcconfig files. > WebKitTools/Scripts/build-webkit:-201 > - The build-webkit script also appears to be missing ENABLE_FULLSCREEN_API support as well.
Created attachment 72103 [details] proposed fix v2
(In reply to comment #5) > Created an attachment (id=72103) [details] > proposed fix v2 - Now the 4 xcconfig is exactly same. - I removed unnecessary variable from build-webkit - I added ENABLE_FULLSCREEN_API support to build-webkit (It is enabled only if isAppleMacWebKit() is true) - I'm sure ENABLE_RUBY should be enabled in WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
Comment on attachment 72103 [details] proposed fix v2 http://trac.webkit.org/changeset/70722 killed me. with adding ENABLE_WEB_AUDIO support :(( I'll update the patch and upload again.
Created attachment 72106 [details] proposed fix v2 Updated to Tot and added ENABLE_WEB_AUDIO to *vsprops
Comment on attachment 72106 [details] proposed fix v2 bad patch, ooops
Created attachment 72107 [details] proposed fix v3
Comment on attachment 72107 [details] proposed fix v3 r=me for the FeatureDefines.xcconfig and build-webkit changes. I can't really speak for the other changes.
CCing Brent Fulgham to review the WinCairo vsprops changes.
Comment on attachment 72107 [details] proposed fix v3 r=me on the .vsprops changes. Thanks for doing this!
David reviewed FeatureDefines.xcconfig and build-webkit changes, and Adam reviewed .vsprops changes. I only need a review for removing unnecessary ENABLE_SANDBOX from all build systems. It is so simple. David or Adam? r?
(In reply to comment #10) > Created an attachment (id=72107) [details] > proposed fix v3 Landed in http://trac.webkit.org/changeset/70878 . ENABLE_METER is enabled in FeatureDefine*.vsprops, because turned of ENABLE_METER cause tests to fail. (rs=aroben for this modification on #webkit)