Bug 48327 – [Qt] Assert due to multiple initialization of WebPlatformStrategies

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[zalan]

https://bugs.webkit.org/show_bug.cgi?id=46078 introduced WebPlatformStrategies::initialize() in QWKPagePrivate::QWKPagePrivate() to initialize the platform strategies in the UI process. Initialization should be done only once, and not per page. Multiple initialization triggers assert in WebCore/PlatformStrategies. The code should mimic the web process side instead. (init is part of the webprocess constuct).

I'll upload a patch soon, which removes the initialization, as it is not needed at all atm.

[zalan]

Created attachment 71990 [details]
remove multiple init

[WebKit Commit Bot]

Comment on attachment 71990 [details]
remove multiple init

Clearing flags on attachment: 71990

Committed r70620: <http://trac.webkit.org/changeset/70620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Balazs Kelemen]

This makes Minibrowser crashing immediately.

[Balazs Kelemen]

Created attachment 72024 [details]
second attempt to fix the original issue

[Andreas Kling]

Comment on attachment 72024 [details]
second attempt to fix the original issue

View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review

r=me, one comment:

> WebKit2/UIProcess/API/qt/qwkpage.cpp:55
> +    if (!initialized) {

Use early return.

[zalan]

oh, sorry. i was about to post the fix on that.

[Balazs Kelemen]

(In reply to comment #6)
> (From update of attachment 72024 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review
> 
> r=me, one comment:
> 
> > WebKit2/UIProcess/API/qt/qwkpage.cpp:55
> > +    if (!initialized) {
> 
> Use early return.

I will. I know that this is the preferred style, but personally I hate that.
There are a lot situations where the early return makes the code harder to read.

[Balazs Kelemen]

Committed in http://trac.webkit.org/changeset/70645