Bug 48315 - Advances are wrong and glyphs are rotated improperly in vertical writing
Summary: Advances are wrong and glyphs are rotated improperly in vertical writing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 46123
  Show dependency treegraph
Reported: 2010-10-26 02:25 PDT by Takumi Takano
Modified: 2010-10-27 05:35 PDT (History)
4 users (show)

See Also:

Proposed patch (49.50 KB, patch)
2010-10-26 04:07 PDT, Takumi Takano
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takumi Takano 2010-10-26 02:25:11 PDT
We shouldn't use vertical metrics for Roman fonts. Also, we should rotate vertical variant glyphs back on drawing as the whole run has already been rotated beforehand.
Comment 1 Takumi Takano 2010-10-26 04:07:35 PDT
Created attachment 71862 [details]
Proposed patch
Comment 2 Dave Hyatt 2010-10-26 11:03:21 PDT
Comment on attachment 71862 [details]
Proposed patch

This looks good.  The tests in fast/blockflow presumably need to be regenerated also, but I can handle that when landing it.
Comment 3 Dave Hyatt 2010-10-26 13:47:28 PDT
Fixed in r70569.
Comment 4 Adam Roben (:aroben) 2010-10-27 05:35:39 PDT
This patch didn't update the Leopard-specific results, so now these tests are failing on Leopard. See http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r70636%20(23255)/results.html