Bug 48299 - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.source-in.html
Summary: Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.source-in.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Wells
URL:
Keywords:
Depends on:
Blocks: 46506
  Show dependency tree / graph
 
Reported: 2010-10-25 22:46 PDT by Mike Lawther
Modified: 2011-11-14 17:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2011-11-09 20:55 PST, Ben Wells 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2010-10-25 22:46:28 PDT 
This layout test fails. See master bug: https://bugs.webkit.org/show_bug.cgi?id=46506
Comment 1 Swapna P 2011-06-06 00:14:39 PDT 
Need to draw transparency in remaining canvas area before drawImage()

This issue is getting solved by adding CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere() & CanvasRenderingContext2D::displayTransparencyElsewhere()  to draw transparency for the remaining canvas area for CompositeSourceIn & CompositeSourceOut. 

As this issue is same as https://bugs.webkit.org/show_bug.cgi?id=48297, for which patch is submitted to Bugzilla. 
Once this patch is committed to main branch, this issue will be solved automatically .
Comment 2 Ben Wells 2011-11-09 20:55:26 PST 
Created attachment 114427 [details]
Patch
Comment 3 Ben Wells 2011-11-09 20:59:06 PST 
These tests are all passing but the expected results were just missing a carriage return.

Also covered by bugs 48296, 48298, 48301, 48300 and 48302.
Comment 4 Ben Wells 2011-11-09 21:00:01 PST 
Comment on attachment 114427 [details]
Patch

Ooops, need to remove from skip files as well.
Comment 5 Ben Wells 2011-11-09 21:06:28 PST 
On second thoughts will create a new bug so the change log title is nice.
Comment 6 Ben Wells 2011-11-14 17:06:05 PST 
Test is passing on all ports now.