Bug 48293 – Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Mike Lawther]

This layout tests fails. See master bug: https://bugs.webkit.org/show_bug.cgi?id=46506

[Julien Chaffraix]

Created attachment 96690 [details]
Proposed fix: Add CompositeDestinationIn to the 'display transparency elsewhere' list

[Julien Chaffraix]

Created attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

[James Robinson]

Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this).  Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing?  The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those.

Other than that this looks great.

[Julien Chaffraix]

Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

> I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this).  Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing?  The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those.

Actually it is already in the test_expectations.txt (see bug 61470) due to the anti-aliasing when clipping out.

[WebKit Review Bot]

Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

Clearing flags on attachment: 96979

Committed r88896: <http://trac.webkit.org/changeset/88896>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.