Bug 48293 - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
Summary: Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 46506
  Show dependency treegraph
 
Reported: 2010-10-25 22:22 PDT by Mike Lawther
Modified: 2011-06-14 19:40 PDT (History)
3 users (show)

See Also:


Attachments
Proposed fix: Add CompositeDestinationIn to the 'display transparency elsewhere' list (12.44 KB, patch)
2011-06-09 19:36 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Proposed fix: Same as previously with a comment about destination-out. (12.64 KB, patch)
2011-06-13 11:20 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2010-10-25 22:22:32 PDT
This layout tests fails. See master bug: https://bugs.webkit.org/show_bug.cgi?id=46506
Comment 1 Julien Chaffraix 2011-06-09 19:36:24 PDT
Created attachment 96690 [details]
Proposed fix: Add CompositeDestinationIn to the 'display transparency elsewhere' list
Comment 2 Julien Chaffraix 2011-06-13 11:20:16 PDT
Created attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.
Comment 3 James Robinson 2011-06-14 15:00:37 PDT
Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this).  Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing?  The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those.

Other than that this looks great.
Comment 4 Julien Chaffraix 2011-06-14 19:00:20 PDT
Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

> I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this).  Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing?  The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those.

Actually it is already in the test_expectations.txt (see bug 61470) due to the anti-aliasing when clipping out.
Comment 5 WebKit Review Bot 2011-06-14 19:40:38 PDT
Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.

Clearing flags on attachment: 96979

Committed r88896: <http://trac.webkit.org/changeset/88896>
Comment 6 WebKit Review Bot 2011-06-14 19:40:42 PDT
All reviewed patches have been landed.  Closing bug.