Bug 48274 - compile TestNetscapePlugIn on chromium linux
Summary: compile TestNetscapePlugIn on chromium linux
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
Depends on:
Reported: 2010-10-25 16:19 PDT by Tony Chang
Modified: 2010-10-27 11:42 PDT (History)
2 users (show)

See Also:

Patch (11.62 KB, patch)
2010-10-25 16:22 PDT, Tony Chang
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-10-25 16:19:05 PDT
compile TestNetscapePlugIn on chromium linux
Comment 1 Tony Chang 2010-10-25 16:22:16 PDT
Created attachment 71810 [details]
Comment 2 Tony Chang 2010-10-25 16:31:56 PDT
This compiles the plugin on Linux, but doesn't put it in a place that DRT will load it.  There are some crashes with this plugin that I want to fix before switching to this plugin.
Comment 3 Kent Tamura 2010-10-25 19:35:04 PDT
Comment on attachment 71810 [details]

Chromium part looks ok.
Comment 4 Tony Chang 2010-10-26 18:14:59 PDT
andersca: Can you review the changes to TestNetscapePlugIn/main.cpp or direct me at someone who would be an appropriate reviewer?
Comment 5 Anders Carlsson 2010-10-27 09:52:35 PDT
Comment on attachment 71810 [details]

This is great! Hopefully it can be a first step towards eliminating the extra unix-specific TestNetscapePlugin implementation! r=me
Comment 6 Tony Chang 2010-10-27 11:42:41 PDT
Committed r70679: <http://trac.webkit.org/changeset/70679>