Bug 48265 - Web Inspector: stub out basic WebInspector API and objects for WebKit2
Summary: Web Inspector: stub out basic WebInspector API and objects for WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Depends on:
Reported: 2010-10-25 14:27 PDT by Timothy Hatcher
Modified: 2010-10-25 16:43 PDT (History)
12 users (show)

See Also:

Proposed Change (37.26 KB, patch)
2010-10-25 14:36 PDT, Timothy Hatcher
andersca: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-10-25 14:27:17 PDT
Stub out basic WebInspector API and objects for WebKit2.
Comment 1 Timothy Hatcher 2010-10-25 14:36:32 PDT
Created attachment 71797 [details]
Proposed Change
Comment 2 Anders Carlsson 2010-10-25 16:22:23 PDT
Comment on attachment 71797 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=71797&action=review

Looks great! r=me with some comments.

> WebKit2/UIProcess/WebPageProxy.h:112
> +    WebInspectorProxy* inspector() const;

I don't think inspector() needs to be const.

> WebKit2/UIProcess/WebPageProxy.h:329
> +    mutable RefPtr<WebInspectorProxy> m_inspector;

And then you can remove mutable here (and get rid of the const_cast in the create function).

> WebKit2/WebProcess/WebPage/WebPage.h:99
> +    WebInspector* inspector() const;

Same comment about inspector being const here.
Comment 3 Timothy Hatcher 2010-10-25 16:43:59 PDT
Landed in r70504.