WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48265
Web Inspector: stub out basic WebInspector API and objects for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48265
Summary
Web Inspector: stub out basic WebInspector API and objects for WebKit2
Timothy Hatcher
Reported
2010-10-25 14:27:17 PDT
Stub out basic WebInspector API and objects for WebKit2.
Attachments
Proposed Change
(37.26 KB, patch)
2010-10-25 14:36 PDT
,
Timothy Hatcher
andersca
: review+
timothy
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2010-10-25 14:36:32 PDT
Created
attachment 71797
[details]
Proposed Change
Anders Carlsson
Comment 2
2010-10-25 16:22:23 PDT
Comment on
attachment 71797
[details]
Proposed Change View in context:
https://bugs.webkit.org/attachment.cgi?id=71797&action=review
Looks great! r=me with some comments.
> WebKit2/UIProcess/WebPageProxy.h:112 > + WebInspectorProxy* inspector() const;
I don't think inspector() needs to be const.
> WebKit2/UIProcess/WebPageProxy.h:329 > + mutable RefPtr<WebInspectorProxy> m_inspector;
And then you can remove mutable here (and get rid of the const_cast in the create function).
> WebKit2/WebProcess/WebPage/WebPage.h:99 > + WebInspector* inspector() const;
Same comment about inspector being const here.
Timothy Hatcher
Comment 3
2010-10-25 16:43:59 PDT
Landed in
r70504
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug