48261 – Web Inspector: continue making resources panel optional.

Bug 48261 - Web Inspector: continue making resources panel optional.

Summary: Web Inspector: continue making resources panel optional.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (Deprecated) (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Pavel Feldman

URL:
Keywords:

Depends on:	48332
Blocks:
	Show dependency tree / graph

Reported:	2010-10-25 13:01 PDT by Pavel Feldman
Modified:	2010-10-26 10:33 PDT (History)
CC List:	13 users (show)

See Also:

Attachments
[PATCH] Proposed change. (26.93 KB, patch) 2010-10-25 13:28 PDT, Pavel Feldman	timothy: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pavel Feldman 2010-10-25 13:01:22 PDT

This refactoring makes console, audits and extensions tests pass while taking data from resource / network panels depending on the flag.

Comment 1 Pavel Feldman 2010-10-25 13:28:32 PDT

Created attachment 71790 [details]
[PATCH] Proposed change.

Comment 2 Pavel Feldman 2010-10-26 06:53:20 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/inspector-test2.js
	M	LayoutTests/http/tests/inspector/resource-parameters.html
	M	LayoutTests/inspector/audits-panel-functional.html
	M	LayoutTests/inspector/styles-source-offsets.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AuditLauncherView.js
	M	WebCore/inspector/front-end/AuditsPanel.js
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/CookieItemsView.js
	M	WebCore/inspector/front-end/ExtensionServer.js
	M	WebCore/inspector/front-end/HAREntry.js
	M	WebCore/inspector/front-end/NetworkPanel.js
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourceCategory.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.js
Committed r70518

Comment 3 WebKit Review Bot 2010-10-26 07:29:47 PDT

http://trac.webkit.org/changeset/70518 might have broken Qt Linux Release
The following tests are not passing:
inspector/audits-panel-functional.html

Comment 4 Pavel Feldman 2010-10-26 10:08:13 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/inspector-test2.js
	M	LayoutTests/http/tests/inspector/resource-parameters.html
	M	LayoutTests/inspector/audits-panel-functional.html
	M	LayoutTests/inspector/styles-source-offsets.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AuditLauncherView.js
	M	WebCore/inspector/front-end/AuditsPanel.js
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/CookieItemsView.js
	M	WebCore/inspector/front-end/ExtensionServer.js
	M	WebCore/inspector/front-end/HAREntry.js
	M	WebCore/inspector/front-end/NetworkPanel.js
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourceCategory.js
	M	WebCore/inspector/front-end/ResourceManager.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.js
Committed r70532

Comment 5 WebKit Review Bot 2010-10-26 10:33:25 PDT

http://trac.webkit.org/changeset/70532 might have broken Qt Linux Release
The following tests are not passing:
inspector/audits-panel-functional.html