Bug 48233 - Add support for loading each test several times in chromium DumpRenderTree
Summary: Add support for loading each test several times in chromium DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 06:32 PDT by Søren Gjesse
Modified: 2010-10-26 10:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch to add multiple load of each test (9.24 KB, patch)
2010-10-25 06:47 PDT, Søren Gjesse
no flags Details | Formatted Diff | Diff
Fixed tabes in ChangeLog file (9.28 KB, patch)
2010-10-25 07:04 PDT, Søren Gjesse
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Søren Gjesse 2010-10-25 06:32:59 PDT
As the code generated by V8 changes as it is running (e.g. when inline caches change state) some bugs needs to have a test loaded several times for it to be revealed. E.g. http://crbug.com/60135. The chromium DumpRenderTree should have support for that.
Comment 1 Søren Gjesse 2010-10-25 06:47:18 PDT
Created attachment 71741 [details]
Patch to add multiple load of each test
Comment 2 WebKit Review Bot 2010-10-25 06:51:21 PDT
Attachment 71741 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Søren Gjesse 2010-10-25 07:04:11 PDT
Created attachment 71744 [details]
Fixed tabes in ChangeLog file
Comment 4 Dimitri Glazkov (Google) 2010-10-25 09:27:46 PDT
Comment on attachment 71744 [details]
Fixed tabes in ChangeLog file

This looks good, but I would like tkent to take a look to make sure this doesn't interfere with his current work.
Comment 5 Kent Tamura 2010-10-25 18:33:05 PDT
Comment on attachment 71744 [details]
Fixed tabes in ChangeLog file

> This looks good, but I would like tkent to take a look to make sure this doesn't interfere with his current work.

No problem.
Comment 6 WebKit Commit Bot 2010-10-26 10:54:57 PDT
Comment on attachment 71744 [details]
Fixed tabes in ChangeLog file

Clearing flags on attachment: 71744

Committed r70537: <http://trac.webkit.org/changeset/70537>
Comment 7 WebKit Commit Bot 2010-10-26 10:55:02 PDT
All reviewed patches have been landed.  Closing bug.